Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-validation Finished_2.00%Error in mult.store[, 2] : subscript out of bounds #12

Open
Markjiancheng opened this issue Oct 28, 2021 · 11 comments

Comments

@Markjiancheng
Copy link

Hi, hope you are doing well.
I am trying KAML for some data but I always get this error:
Cross-validation Finished_2.00%Error in mult.store[, 2] : subscript out of bounds

And this for a different data:
Pick up pseudo QTNs at LD threshold(0.3) as following:
Error in if (sum(p_cor > cor.threshold) == 0) bin.qtn[[g]] <- c(bin.qtn[[g]], :
missing value where TRUE/FALSE needed

Would you please help with these issues? Thanks!

@YinLiLin
Copy link
Owner

Hi Mark,

Thanks for trying KAML, we haven't caught this error by now using the data in hand, may i please ask for a small dataset which can repeat the error as you proposed? i am pleased to debug the script of KAML for this issue, and feed back to you as soon as possible.

Best,
Lilin

@Markjiancheng
Copy link
Author

Hi YinLiLin,

Thanks for your prompt reply, I actually tried the horse and maize data that you used in your paper, but I am not sure why both of them did not work.
Attached is the exact code and data I used, please see attached
GDD.zip
Horse.zip
!

@YinLiLin
Copy link
Owner

YinLiLin commented Nov 1, 2021

Hi, I just tried both of the data attached, it works fine on my computer, the LOG information can be found below:
horse.log
GDD.log
Did you use the latest version of KAML that was installed from Github?

@Markjiancheng
Copy link
Author

I think so. I just installed according to the instruction recently.

@YinLiLin
Copy link
Owner

YinLiLin commented Nov 5, 2021

Thank you for pointing out this issue, we have located the problem, and the latest script on GitHub can be run successfully on different version of R, please try again.

@Markjiancheng
Copy link
Author

Thanks for checking it out, however, the problem still exist:
Error in if (sum(p_cor > cor.threshold) == 0) bin.qtn[[g]] <- c(bin.qtn[[g]], :
missing value where TRUE/FALSE needed

Moreover, it looks like computing grm took me longer than before, is it because that you updated the package?

@YinLiLin
Copy link
Owner

YinLiLin commented Nov 5, 2021

Yes, we have changed the computing strategy for GRM construction, it take less memory than previous version. Can the updated version run "horse" and "GDD" data successfully on your computer? Or it just failed for your own data? if in this case, could you mind sending me a small data? i need to repeat this issue to get it fixed.

@Markjiancheng
Copy link
Author

No, it failed on the GDD data.

@YinLiLin
Copy link
Owner

YinLiLin commented Nov 8, 2021

May i know the version of R you used and the operating system (linux, windows, mac) of your computer?

@Markjiancheng
Copy link
Author

It is R 4.1.1 in Linux.

@YinLiLin
Copy link
Owner

I just ran KAML at the same environment as yours (R 4.1.1, Linux), it can still work without problem, please see the log file below:
KAML_R-4.1.1_run.log
Sorry that it seems there may be potential problem which would be encountered at specify systematical environment, so I recommend to have a try at another computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants