Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setTableName method on User mapper #552

Open
adamlundrigan opened this issue Jan 15, 2015 · 4 comments
Open

Remove setTableName method on User mapper #552

adamlundrigan opened this issue Jan 15, 2015 · 4 comments

Comments

@adamlundrigan
Copy link
Contributor

Should be replaced by a constructor argument instead? AFAIK there isn't a good use case for being able to change the table name after the mapper is constructed.

This would have to be targed to v2.0 as it's a BC break to remove the setter.

@ojhaujjwal
Copy link
Contributor

+1

@stijnhau
Copy link

Indead totaly agreeing with it.
Create a PR and it probabaly will be accepted

@adamlundrigan
Copy link
Contributor Author

It's percolating it's way up through my TODO list ;)

@adamlundrigan
Copy link
Contributor Author

I've incorporated this into my refactor of the Mapper layer (#559)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants