Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login-failed error misplaced within formElementErrors #640

Open
intellent opened this issue May 14, 2016 · 1 comment
Open

Login-failed error misplaced within formElementErrors #640

intellent opened this issue May 14, 2016 · 1 comment

Comments

@intellent
Copy link

Hey everyone,

I noticed an odd behavior, regarding the “Authentication failed. Please try again.” message, after having entered wrong credentials in the login form. The message is rendered within the $this->formElementErrors($element) call of the identity element. To me this seems semantically incorrect, since it’s not an error of the identity element but of the form itself. Furthermore it doesn’t look good, if a global error is rendered within the context of a form field.

I investigated the code and found out that the message is actually send via FlashMessenger here.

This looks right. But my flash messenger does not render the message in its appropriate place. Instead it ends up in the formElementErrors. I have no idea why.

Regards
André

@jarrettj
Copy link

jarrettj commented Nov 1, 2017

Can't get error displaying as well.
+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants