Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libsignal-service-rs ? #5

Open
rubdos opened this issue Apr 5, 2021 · 5 comments
Open

Use libsignal-service-rs ? #5

rubdos opened this issue Apr 5, 2021 · 5 comments

Comments

@rubdos
Copy link

rubdos commented Apr 5, 2021

Hey! Full disclosure: I'm one of the main people behind https://github.com/Michael-F-Bryan/libsignal-service-rs/. I wonder why you folks rolled your own, and what would be missing in our library such that we can help each other? We already have unidentified senders (#4), for instance.

Want to team up?

@survived
Copy link

survived commented Apr 5, 2021

Hi @rubdos! Actually I simply missed this amazing crate when I was googling something similar. It can significantly simplify our code! My only concern is why are you still using bindings to libsignal-client-c whereas there're great pure Rust implementation of it? For instance, it provides async-friendly stores traits (PreKeyStore, etc). Maybe I can help you with whisperfish/libsignal-service-rs#72?

@rubdos
Copy link
Author

rubdos commented Apr 5, 2021

I thought you would be raising that concern. The only reason is lack of time/putting focus on other things. Please do feel free to help us with whisperfish/libsignal-service-rs#72 !

And also, please do feel free to post issues and questions. If you're into Matrix or IRC, feel free to come have a chat on #whisperfish:rubdos.be or #whisperfish on Freenode, it's where we coordinate this effort.

Another unspoken rule: we still very often break public interface in libsignal-service. So if you're patching stuff, feel free to break things!

@rubdos
Copy link
Author

rubdos commented Apr 28, 2021

FYI, our move to libsignal-client is finishing up: whisperfish/libsignal-service-rs#83 ! Join the water, it's warm ;-)

Meanwhile, we've moved to https://github.com/whisperfish/, which encompasses a bunch of third-party Signal libraries, and we're in contact with Signal about moving some primitives over to them.

@survived
Copy link

Thank you for keeping up to date! We will switch on libsignal-client shortly after whisperfish/libsignal-service-rs#83 is merged

@survived
Copy link

we've moved to https://github.com/whisperfish/

I saw all this story with choosing right license (GPLv3 / AGPLv3) and signing CLA. Tricky journey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants