Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate time formatting logic into shared utilities #2

Open
aaronfuj opened this issue Jan 18, 2021 · 0 comments
Open

Consolidate time formatting logic into shared utilities #2

aaronfuj opened this issue Jan 18, 2021 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@aaronfuj
Copy link
Owner

Use of Date object and formatting in Javascript isn't great towards ensuring everything is shown with the correct values. This issue is to ensure that there is a consolidated location of formatting the time and it gets properly shown in a unified way. Some specifics to consider:

  • Time on charts (what should be shown, local or HST?)
  • Time on forecasts (show HST, imo)
  • Time on tide tables (show time corresponding to location, i.e. HST)
  • Time for sunrise/sunset (show time corresponding to location, i.e. HST)

Sources of information:

  • Buoy
  • Tide
  • Hawaii state forecast
  • Sunrise/Sunset calculator
@aaronfuj aaronfuj added bug Something isn't working enhancement New feature or request labels Jan 18, 2021
@aaronfuj aaronfuj self-assigned this Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant