Fix problem not allowing accrual of indexes when RF (Reserve Factor) is configured as 100% #315
Comments
eboadom
added a commit
to bgd-labs/protocol-v2
that referenced
this issue
Oct 13, 2022
- Changed condition for when indexes should be updated on _updateIndexes(). - Added condition to not do any update on updateState() if time has not passed since the previous update. - Moved update location of reserve.lastUpdateTimestamp.
eboadom
added a commit
to bgd-labs/protocol-v2
that referenced
this issue
Oct 20, 2022
eboadom
added a commit
to bgd-labs/protocol-v2
that referenced
this issue
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
The problem/consequences are explained HERE.
How
Having a 100% RF is a legitimate configuration for a reserve, so the fix should be on the logic not properly handling that case, instead of only adding extra validation to not allow a set of 100%.
To be researched deeper, but highly probable that the change should be done around the condition of ReserveLogic not contemplating the 100% RF scenario.
Other initial aspects to consider:
Gas implications of the fix should be checked.
New tests should be added for the 100% RF case.
The fix should be applied on both the v2 version deployed on Polygon/Avalanche and the one on Aave v2 Ethereum. Initially, in what concerns this part of the logic, they should be exactly the same.
Aave v2 Ethereum Fix for #315 (v2 Ethereum) #317
Aave v2 Polygon Fix for #315 (v2 Polygon) #316
Aave v2 Avalanche Fix for #315 (Aave v2 Avalanche) #318
The text was updated successfully, but these errors were encountered: