-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging #19
Comments
I think its low priority |
Generally agree, but let me refocus a bit. Do we need log at the frontpage ? (I'd suggest removing it) |
I find the logging on the frontpage quite useful. What you saw in abaplint/abaplint-sci-client#188 could have been identified that way, for example (if I had looked ;-) ). Instead of the last 10 requests, it would make a bit more sense to show all requests from the last 5 min or so. This would make it easier to correlate client and server activities. |
if it's useful, then it's useful, no prob :) |
btw: @mbtools @larshp how do you run this thing ? I mean, I just so natively run and see it from command line that tools like that frontpage look for me very unnatural. What is your use case ? @ed-holland uses portainer as I undersood, there should be the console log output |
What kind of logging is required ? And what are the levels?
Currently there is that
addInfo
that keeps last 10 requests and visible from the frontpage.In reality I think there are 3 categories of entries:
I think all of the can go to console. Docker can redirect that to any other service "in production".
On the other hand there is the public service. Do you suppose to leave it ? Anyway I think the logs should be hidden from there and better to redirect it to a logging service, maybe even public one.
@larshp what do you think ?
The text was updated successfully, but these errors were encountered: