Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging #19

Open
sbcgua opened this issue Mar 24, 2020 · 6 comments
Open

Logging #19

sbcgua opened this issue Mar 24, 2020 · 6 comments

Comments

@sbcgua
Copy link
Collaborator

sbcgua commented Mar 24, 2020

What kind of logging is required ? And what are the levels?

Currently there is that addInfo that keeps last 10 requests and visible from the frontpage.

In reality I think there are 3 categories of entries:

  • requests (maybe just in "dev" mode) and time of their serving (this what morgan does in the PR)
  • details of check_object (also debug in fact ? or needed for statistics?)
  • errors

I think all of the can go to console. Docker can redirect that to any other service "in production".

On the other hand there is the public service. Do you suppose to leave it ? Anyway I think the logs should be hidden from there and better to redirect it to a logging service, maybe even public one.

@larshp what do you think ?

@larshp
Copy link
Member

larshp commented Mar 24, 2020

I think its low priority

@sbcgua
Copy link
Collaborator Author

sbcgua commented Mar 24, 2020

Generally agree, but let me refocus a bit. Do we need log at the frontpage ? (I'd suggest removing it)

@mbtools
Copy link
Contributor

mbtools commented Oct 9, 2020

I find the logging on the frontpage quite useful. What you saw in abaplint/abaplint-sci-client#188 could have been identified that way, for example (if I had looked ;-) ).

Instead of the last 10 requests, it would make a bit more sense to show all requests from the last 5 min or so. This would make it easier to correlate client and server activities.

@sbcgua
Copy link
Collaborator Author

sbcgua commented Oct 10, 2020

if it's useful, then it's useful, no prob :)
Just to clearly understand the purpose - it is not scalable, only for quick dev.

@sbcgua
Copy link
Collaborator Author

sbcgua commented Oct 10, 2020

btw: @mbtools @larshp how do you run this thing ? I mean, I just so natively run and see it from command line that tools like that frontpage look for me very unnatural. What is your use case ? @ed-holland uses portainer as I undersood, there should be the console log output

@ed-holland
Copy link

Details are showing up like this (using verbose=1)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants