-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support other distance metrics #11
Comments
Followup -- I started working on supporting additional distance functions. API question -- the current API exports a |
BTW, will yourchanges to introduce additional metrics support this 2 notions of distances for same metric (if needed), like normal dist for public API and "squared" internally? |
@eigenhombre Yes, I'd absolutely welcome a PR! I like the notion of having the API expose I'm not sure how widespread use of this library is, but it might be friendlier to deprecate |
I like the more general |
Currently the (square of the) Euclidean distance is the only metric allowed, with the simplest (i.e., non-wrapping) topology. I'd be interested in getting this to work on e.g. a sphere with the Haversine (great circle) distance. Use cases for this include distances on the Earth (GIS). @abscondment would you welcome a PR for that?
The text was updated successfully, but these errors were encountered: