Added roman and alphanumeric list feature #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhajit Ghosh <[email protected]>
|
I have only added the Roman list feature as of now. Any suggestion for an alphanumeric list @dselman |
Signed-off-by: Subhajit Ghosh <[email protected]>
Signed-off-by: Subhajit Ghosh <[email protected]>
|
hey @sanketshevkar @DianaLease can you guys review this pr and give me a feedback ? |
Signed-off-by: Subhajit Ghosh <[email protected]>
|
Can you please add a unit test / screenshot / screen-recording whichever you feel that can help us verify the changes you've made? Thanks. |
Have one confusion that in the issue @dselman mentioned the markdown should have roman and alphanumeric |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes accordproject/template-playground#10
Added roman and alphanumeric list feature
Author Checklist
--signoffoption of git commit.mainfromfork:branchname