Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support multiple packages #65

Open
Niek opened this issue Feb 26, 2022 · 9 comments
Open

[Feature Request] Support multiple packages #65

Niek opened this issue Feb 26, 2022 · 9 comments

Comments

@Niek
Copy link

Niek commented Feb 26, 2022

Right now just a single package is supported with package-name. I tried specifying a list but that doesn't work. It would be great if multiple packages could be supported.

@NamrataJha
Copy link
Contributor

Hey @Niek great idea but I believe action matrices might come in handy for this ask. With matrices you can configure your workflow to run on multiple packages in parallel and even customise the workflow further.

@Niek
Copy link
Author

Niek commented Mar 3, 2022

@NamrataJha Matrices work great, but they require a separate job with matrix strategy to clean up the packages (instead of a single step inside a job). But I do understand if you don't want to clutter the code with supporting multiple package names.

@OmarCastro
Copy link

I have developed this feature in a fork. I am aware of action matrices, and the code clutter that will be added to the code. But I still believe it is worth the price as it can simplify this action's configuration.

@carlos-m-rodrigues
Copy link

Hello @NamrataJha, did you already analyzed the PR from @OmarCastro? It will be integrated?

@NamrataJha
Copy link
Contributor

Hey @carlos-m-rodrigues @OmarCastro need some time for this. Will take a look in the week of April 18.

@carlos-m-rodrigues
Copy link

Hi @NamrataJha is there any update in this subject?

@bjornbouetsmith
Copy link

bjornbouetsmith commented Sep 30, 2022

I came here looking for multi package deletion suport - but with matrixes I think this is not really required - since you can do this:

name: Cleanup packages

on:
  schedule:
  - cron: "0 5 * * *"

  workflow_dispatch:

jobs:
  clean:
    strategy:
      matrix:
        package: ['First.Id.Of.Package', 'Second.Id.Of.Package']
    runs-on: ubuntu-latest

    steps:
      - name: Delete Package
        uses: actions/delete-package-versions@v3
        with: 
          package-name: ${{ matrix.package }}
          min-versions-to-keep: 10
          delete-only-pre-release-versions: "false"

So unless you want to clean packages as part of a ci pipeline - I don't think its such a big issue :-)

But anyway - the above is an example until/if its natively supported

@hfhbd
Copy link

hfhbd commented Nov 20, 2022

What about just supporting a regex for all (string) input?

@utrescu
Copy link

utrescu commented Feb 21, 2024

The difference of deleting multiple packages via matrixes is billable time.

We are cleaning 32 different old packages via matrix and the result is:
image

And if we clean all packages in a single job:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants