Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Messaging on first merge PR #226

Open
brucearctor opened this issue Feb 21, 2023 · 10 comments
Open

Support Messaging on first merge PR #226

brucearctor opened this issue Feb 21, 2023 · 10 comments

Comments

@brucearctor
Copy link

brucearctor commented Feb 21, 2023

Would this be the correct GH Action to also have a message on first merge of a PR? Or that would be after the 'first interaction' and therefore something better off elsewhere?

I would be happy to extend this action to include messaging on FirstPRMerge. Like: https://github.com/behaviorbot/welcome#first-pr-merge

If I submitted a PR is that something that would be welcome/reviewed/included? Or outside the scope of this GH Action?

@github-actions
Copy link

Hello! Thank you for filing an issue.

If this is a bug report, please include relevant logs to help us debug the problem.

@kartben
Copy link

kartben commented Mar 22, 2023

+1, this would be a nice addition

@kartben
Copy link

kartben commented Mar 22, 2023

Hey actually I just ended up implementing the change -- see https://github.com/kartben/first-interaction/tree/v1.1.2-fork. This will greet someone on their first merged PR (which might not be their first PR ever, but really the first that's being merged into the repo)

I will echo @brucearctor question, and ask if someone from the project would like me to submit a PR? If that's the case indeed, I'm realizing just now that my fork might require a few changes to make sure that the new version actually remains backward-compatible, i.e. I probably should refrain from renaming message keys.

@cory-miller @TingluoHuang

@brucearctor
Copy link
Author

brucearctor commented Mar 22, 2023

Awesome! FYI -> I'm hoping to use for some messaging around: https://news.apache.org/foundation/entry/the-asf-launches-firstasfcontribution-campaign. [ in some specific ASF projects ] ... there is some opposition/hesitation to use probot, so this would be great to use!

@kartben
Copy link

kartben commented Mar 22, 2023

Awesome! FYI -> I'm hoping to use for some messaging around: https://news.apache.org/foundation/entry/the-asf-launches-firstasfcontribution-campaign. [ in some specific ASF projects ] ... there is some opposition/hesitation to use probot, so this would be great to use!

Very cool! FWIW here's what I have drafted for our open-source project: https://github.com/kartben/delete-me4/blob/main/.github/workflows/blank.yml, in case this is useful to you somehow :)

@The11sun
Copy link

The11sun commented Mar 22, 2023 via email

@The11sun
Copy link

The11sun commented Mar 22, 2023 via email

@kartben
Copy link

kartben commented Mar 28, 2023

ping @cory-miller @TingluoHuang. I'd rather not fork the action if you guys would be considering a PR for this (as a reminder, the branch lives here: https://github.com/kartben/first-interaction/tree/v1.1.2-fork)

Thank you!

@kartben
Copy link

kartben commented Apr 11, 2023

FWIW the Zephyr Project went ahead and will be using this fork going forward: https://github.com/zephyrproject-rtos/action-first-interaction/tree/v1.1.2-zephyr. I would still very much be interested in contributing this functionality back upstream if there is interest?

@Swastyy
Copy link

Swastyy commented Mar 4, 2024

Hi @kartben , I was looking into this first merged greet message action and since the github action doesn't allows it for now, can you please guide me on how to use https://github.com/kartben/first-interaction/tree/v1.1.2-fork on my project repo. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants