Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do cpedantic for stdlib & testing #805

Open
plajjan opened this issue Aug 15, 2022 · 1 comment
Open

Do cpedantic for stdlib & testing #805

plajjan opened this issue Aug 15, 2022 · 1 comment
Assignees
Labels
Compiler Related to the Acton compiler enhancement New feature or request
Milestone

Comments

@plajjan
Copy link
Contributor

plajjan commented Aug 15, 2022

We should compile stdlib and our test with --cpedantic.

We've concluded in the past that cpedantic can't be enabled per default since it depends on the CC version, and we don't want our use base to be guinea pigs. However, for compiling stdlib and test , i.e. acton itself, we should be fine. Last week I spent a few hours too many on debugging something that would have been caught with --cpedantic.

Outstanding things to fix:

@plajjan plajjan added enhancement New feature or request Compiler Related to the Acton compiler labels Aug 15, 2022
@plajjan plajjan added this to the Base milestone Aug 15, 2022
@plajjan plajjan self-assigned this Nov 4, 2022
@plajjan
Copy link
Contributor Author

plajjan commented Aug 15, 2023

We now use a particular version of zig so we don't rely on a system CC and thus we can always use --cpedantic.

--cpedantic actually broke a bit with the restructuring to use build.zig and it was never implemeneted for project builds but that is now fixed with #1440 and #1441.

I think we should start to fix these errors, one by one, until they're all fixed and we can permanently enable it. It can be temporarily enabled by like so

CPEDANTIC=1 make

@sydow do you want to start to take a stab at fixing various compilation warnings/errors? :)

@plajjan plajjan mentioned this issue Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compiler Related to the Acton compiler enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant