[Bug]: Bank-Sync Rate Limit error handling

[xrebelox]

Verified issue does not already exist?

• I have searched and found no existing issue
• I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

It seems some institutions set a daily rate limit which is fine, however, Actual provides a generic error This account is experiencing connection problems. Let's fix it. when you click to check said error it just shows like this:

Checking the docker logs I can see that the error is as follows:

{
  summary: "Couldn't update account transactions",
  detail: 'Daily request limit set by the Institution has been exceeded.',
  status_code: 429,
  type: 'RateLimitError'
}

I looked into the code and we're already handling the RateLimitError but it seems that the error sent to the front-end is not correct (I checked the network requests and the error was sent when hitting the /gocardless/transactions), here's the response from the API:

{
    "status": "ok",
    "data": {
        "error_type": "SYNC_ERROR",
        "error_code": "NORDIGEN_ERROR"
    }
}

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Linux

[totalitarian]

Same issue

[denkristoffer]

It would be nice if this was handled better because GoCardless has begun to heavily rate limit:

Starting from 19 August 2024, we will implement a limit of 10 API requests per day for each access scope (details, balances, transactions) on account id level as part of our ongoing efforts to enhance operational effectiveness and minimize potential issues for all our clients. This phased approach will allow us to optimize our services progressively.

We plan to establish a limit of four requests per day for each access scope in the next phase.

From an email they sent out a couple of weeks ago. I still don't see this limit being mentioned in their docs.

[totalitarian]

It would be nice if this was handled better because GoCardless has begun to heavily rate limit:

Starting from 19 August 2024, we will implement a limit of 10 API requests per day for each access scope (details, balances, transactions) on account id level as part of our ongoing efforts to enhance operational effectiveness and minimize potential issues for all our clients. This phased approach will allow us to optimize our services progressively.
We plan to establish a limit of four requests per day for each access scope in the next phase.

From an email they sent out a couple of weeks ago. I still don't see this limit being mentioned in their docs.

Damn, 4 per day is going to hurt

[matt-fidd]

This should be fixed in latest as long as you're running the most recent server and front end.

actualbudget/actual-server#439

[matt-fidd]

There's an issue tracking this actualbudget/actual-server#431