Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GARepertoire converts genotypes to floats aggressively #168

Open
blacksph3re opened this issue Jan 9, 2024 · 1 comment
Open

GARepertoire converts genotypes to floats aggressively #168

blacksph3re opened this issue Jan 9, 2024 · 1 comment

Comments

@blacksph3re
Copy link

In the genotypes repertoire init function, a all-zero repertoire is created of the default dtype float. All following interactions with that repository silently convert genotypes to float.

If the genotypes are of another dtype like ints, this might induce problems down the line. For example, integers greater than 2**24 will not be stored correctly and very hard-to-debug problems ensue.

I don't see the reason why enforcing float dtype is necessary here.

@Lookatator
Copy link
Member

Hi @blacksph3re , thank you very much for this issue.
Totally agree with you! In that case, can we simply enforce the type with dtype=x.dtype?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants