Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate inputstream.adaptive #1

Open
dagwieers opened this issue Mar 17, 2020 · 20 comments
Open

Translate inputstream.adaptive #1

dagwieers opened this issue Mar 17, 2020 · 20 comments
Assignees
Labels
new New translation request translations Related to translations

Comments

@dagwieers
Copy link
Contributor

dagwieers commented Mar 17, 2020

As a first task we could take up translating inputstream.adaptive as widely as possible. This add-on is a good starter as it is reasonably simple (only 24 strings) and it is used by a lot of video plugins nowadays.

You can find the translations at:
https://github.com/peak3d/inputstream.adaptive/tree/Matrix/inputstream.adaptive/resources/language

Here is the list of Kodi-addons languages and their status. (See the error log below)

Legend Meaning
✔️ Translation complete
⚠️ Missing strings or syntax problems
No translations
Language ISO Status Last translator PR
Bosnian bs_ba
Bulgarian bg_bg
Montenegrin cnr_me
Czech cs_cz
Danish da_dk
German de_de ✔️ @horstle xbmc/inputstream.adaptive#409
Greek el_gr ✔️ @Twilight0 xbmc/inputstream.adaptive#401
English en_gb (default language)
Spanish es_es ✔️ @roliverosc xbmc/inputstream.adaptive#407
Mexican es_mx
Finnish fi_fi
French fr_fr ⚠️ @brunoduc OK
Hebrew he_il
Croatian hr_hr ✔️ @arvvoid xbmc/inputstream.adaptive#406
Hungarian hu_hu ✔️ @frodo19
Hindi in_hi ✔️ @TAHIRDON xbmc/inputstream.adaptive#410
Italian it_it ⚠️ @CastagnaIT
Japanese ja_jp ⚠️ @Thunderbird2086
Korean ko_kr ⚠️ @Thunderbird2086
Lithuanian lt_lt
Latvian lv_lv
Macedonian mk_mk
Norwegian nb_no
Dutch nl_nl ✔️ @dagwieers xbmc/inputstream.adaptive#402
Polish pl_pl ⚠️ @notoco
Brazilian pt_br
Portuguese pt_pt
Romanian ro_ro ✔️ @tmihai20 xbmc/inputstream.adaptive#404
Russian ru_ru ✔️ @vlmaksime xbmc/inputstream.adaptive#403
Serbian sr_rs
Slovak sk_sk ✔️ @matejmosko xbmc/inputstream.adaptive#399
Slovenian sl_si
Swedish sv_se ✔️ @Sopor OK
Turkish tr_tr
Taiwanese zh_tw

NOTE: Not all past translators have accepted the invitation yet.

Translation errors

[dag@moria inputstream.adaptive]$ make language
= Starting language test
resources/language/resource.language.ja_JP/strings.po:109: this message is untranslated
resources/language/resource.language.ja_JP/strings.po:109: warning: this message is not used
msgcmp: found 1 fatal error
msgcmp: input file doesn't contain a header entry with a charset specification
resources/language/resource.language.en_gb/strings.po:117: this message is used but not defined in resources/language/resource.language.in_hi/strings.po
msgcmp: found 1 fatal error
resources/language/resource.language.fr_fr/strings.po:109: this message is untranslated
resources/language/resource.language.fr_fr/strings.po:109: warning: this message is not used
msgcmp: found 1 fatal error
resources/language/resource.language.it_it/strings.po:109: this message is untranslated
resources/language/resource.language.it_it/strings.po:109: warning: this message is not used
msgcmp: found 1 fatal error
resources/language/resource.language.ko_KR/strings.po:61: this message is untranslated
resources/language/resource.language.ko_KR/strings.po:109: this message is untranslated
resources/language/resource.language.ko_KR/strings.po:61: warning: this message is not used
resources/language/resource.language.ko_KR/strings.po:109: warning: this message is not used
msgcmp: found 2 fatal errors
resources/language/resource.language.pl_pl/strings.po:85: this message is untranslated
resources/language/resource.language.pl_pl/strings.po:89: this message is untranslated
resources/language/resource.language.pl_pl/strings.po:109: this message is untranslated
resources/language/resource.language.pl_pl/strings.po:85: warning: this message is not used
resources/language/resource.language.pl_pl/strings.po:89: warning: this message is not used
resources/language/resource.language.pl_pl/strings.po:109: warning: this message is not used
msgcmp: found 3 fatal errors

cc @peak3d @add-ons/translators

@dagwieers dagwieers added the translations Related to translations label Mar 17, 2020
@Twilight0
Copy link

Some greek strings were left untranslated intentionally because the same are for the greek language. I think the same applies to other languages as well. For instance 1080p etc.

@dagwieers
Copy link
Contributor Author

@Twilight0 I think it would be best if we translate them to the same value. That is the only way to know if this was untranslated intentionally or accidentally. Feel free to fix this for other languages as well if you are proposing this upstream.

@Twilight0

This comment has been minimized.

@dagwieers

This comment has been minimized.

@matejmosko
Copy link

I have slovak translation ready. How can I apply?

@dagwieers
Copy link
Contributor Author

dagwieers commented Mar 17, 2020

@matejmosko I guess we should add some instructions to the wiki, but there are 2 options:

  • Add a new file through the GitHub web interface in the right location (this will create a fork and make a PR)
  • Clone the repository to your local machine, fork it on GitHub, add your fork as a remote, make a branch for your changes, commit your changes to the branch, push to your fork, make a PR from GitHub.

@matejmosko
Copy link

Hi, thanks, i've used the first way. My problem was in guessing the right location. First, when I tried, I was not able to do because of notenought permissions to create a file. I was probably in the wrong folder.

@dagwieers
Copy link
Contributor Author

@matejmosko I noticed you made the branch in your local fork (https://github.com/matejmosko/inputstream.adaptive/tree/patch-1), but you did not turn it into a PR yet.

If you go to https://github.com/peak3d/inputstream.adaptive/pulls there should be a box offering to create a PR for you.

@tmihai20
Copy link

I made PR xbmc/inputstream.adaptive#404 and added Romanian translation.

@dagwieers dagwieers pinned this issue Mar 19, 2020
@roliverosc-zz
Copy link
Collaborator

Before I had translate spanish language for inputstream.adaptive .

@dagwieers
Copy link
Contributor Author

dagwieers commented Mar 27, 2020

@roliverosc There was a new string added recently. That is why it is listed as incomplete above.
See: https://github.com/peak3d/inputstream.adaptive/pull/402/files#diff-9d264382dc5f3fb87e21a6906c4d56e1

@roliverosc-zz
Copy link
Collaborator

Ok i am sorry I had forgotten. What is differences between "Manual" and "Manual Video"?

msgctxt "#30156"
msgid "Manual"
msgstr "Manual"

msgctxt "#30160"
msgid "Manual video"
msgstr "Show all video streams"

@arvvoid
Copy link

arvvoid commented Mar 28, 2020

Updated Croatian (hr_hr) translation xbmc/inputstream.adaptive#406

@dagwieers dagwieers added the new New translation request label Mar 29, 2020
@dagwieers dagwieers self-assigned this Mar 29, 2020
@horstle
Copy link

horstle commented Mar 30, 2020

Updated german: xbmc/inputstream.adaptive#409

@spyderboy92
Copy link

HI, I have added Hindi(India) translation xbmc/inputstream.adaptive#410

@jotakswe
Copy link

@peak3d @dagwieers
A working Swedish translation.
strings_sv_SE-2.4.5.po.txt

@dagwieers
Copy link
Contributor Author

@jotakswe Did you try to submit this to the project? If you need guidance, let me know and I will (finally) document this on the Wiki 😉

@jotakswe
Copy link

@dagwieers

When I submit a translation file to "plugin.video.netflix" I do exactly the same thing as I have done here, for this project. And that's OK for CastagnaIT, because he puts the file in the project for me.
This is because I do not know how, or can not make a PR, or as you call it, a "submit" to this project.
I also have no desire to learn how to do this either, because I suffer from a severe fatigue syndrome, (if you don't know what it is, then use Google to find out what it means), and I think it's enough to do the translation for the project.
You have the translation here now, and it works unlike the one now available. Do whatever you want with it, but if you use it, don't forget to give me credit for it as well.

Then you can check out why the translation folder "resource.language.sk_sk" is one level before "inputstream.adaptive/inputstream.adaptive/resources/language/", The folder should probably be under the "language"folder and not under the "resources" folder. But that is your problem, I don't care, but wanted to make you aware of this.

@jotakswe

@dagwieers
Copy link
Contributor Author

@Sopor We had hoped that all translators (having a Triage role) could update the issue descriptions, but apparently this is not the case. I am not sure if using tickets is the best way forward, but I also don't know what would work better. At least here people can subscribe to get updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New translation request translations Related to translations
Projects
None yet
Development

No branches or pull requests

10 participants