Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skins does not change Primefaces components colors. #146

Open
mnesarco opened this issue Dec 26, 2018 · 1 comment
Open

Skins does not change Primefaces components colors. #146

mnesarco opened this issue Dec 26, 2018 · 1 comment

Comments

@mnesarco
Copy link

Issue Overview

I have tested all skins: navbar and menu colors are set by the skin, but links, buttons, table headers, panels, etc remain the same: bluesy.

Current Behaviour

Skin does not affect primefaces components colors.

Expected Behaviour

Skins should set colors for everything.

How to reproduce
Additional Information
  • AdminFaces version: 1.0.0.RC19
  • PrimeFaces version: 6.2
  • JSF implementation: 2.3
@rmpestano
Copy link
Contributor

rmpestano commented Jan 28, 2019

Hi @mnesarco,

sorry for the delayed reply.

For now this behavior is "by design", it is how it works on admin-lte, see here. However this is quite possible to implement but we would need to discuss how every component would work, for example how btn-primary should look like on skin-red? and btn-danger? both would be red?

IN terms of implementation it is quite easy to change the colors of components based on the skin because the skin name is on the body of the page...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants