Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transaction names consistent between repositories #1145

Closed
davidyuk opened this issue Apr 6, 2021 · 1 comment
Closed

Make transaction names consistent between repositories #1145

davidyuk opened this issue Apr 6, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@davidyuk
Copy link
Member

davidyuk commented Apr 6, 2021

Make transaction names consistent between repositories

For example, "name pre-claim" transaction:

namePreClaim: 'namePreClaimTx',

https://github.com/aeternity/aepp-sdk-elixir/blob/a001b0eb264665623c9b05de25a71d1f13990679/lib/utils/transaction.ex#L32

https://github.com/aeternity/elixir-node/blob/d35613f5541a9bbebe61f90b8503a9b3416fe8b4/apps/aecore/lib/aecore/naming/tx/name_pre_claim_tx.ex#L1

https://github.com/aeternity/aesophia_aci_encoder/blob/41d0427391ad9c153a5af1a4dcb9b361c4f425b0/src/aeaci_aci.erl#L219

to avoid the stuff like:

export const TX_TYPES_MDW = {
   SpendTx: TX_TYPE.spend,
   ContractCallTx: TX_TYPE.contractCall,
   ContractCreateTx: TX_TYPE.contractCreate,
   NamePreclaimTx: TX_TYPE.namePreClaim,
   NameClaimTx: TX_TYPE.nameClaim,
   NameBidTx: TX_TYPE.nameClaim,
   NameUpdateTx: TX_TYPE.nameUpdate,
 };

https://github.com/aeternity/superhero-wallet/pull/951/files?short_path=5c093c4#diff-0453e03088f470724b3f8c7c0879c03547a84ec4bf1e0b0e241f4396243c6e08R16-R24

@davidyuk davidyuk added the enhancement New feature or request label Apr 6, 2021
@davidyuk
Copy link
Member Author

davidyuk commented Aug 2, 2022

SDK choosed https://github.com/aeternity/aeserialization as a source of truth in #1622

@davidyuk davidyuk closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant