Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The decoded value type shouldn't change depending on its magnitude in state channels #1926

Open
davidyuk opened this issue Dec 21, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@davidyuk
Copy link
Member

https://github.com/aeternity/aepp-sdk-js/blob/2f15b5cbe9426d9170f51e469212b8bcb9bf9228/src/utils/json-big.ts
Because of json-bigint implementation we are using, the big values in FSM responses are parsed as strings, but the small ones are parsed as numbers. This is very confusing and error-prone.

@davidyuk davidyuk added the bug Something isn't working label Dec 21, 2023
@davidyuk davidyuk added this to the v13.3.0 milestone Feb 2, 2024
@davidyuk davidyuk modified the milestones: v13.3.0, v13.4.0 Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant