Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final reviews count can be wrong if there were cancelled sessions that have been reviewed #232

Open
hugocorbucci opened this issue Jul 2, 2016 · 1 comment

Comments

@hugocorbucci
Copy link
Member

hugocorbucci commented Jul 2, 2016

If we discover that sessions need to be cancelled after the review process has already started, there is the possibility that the session to be cancelled already has a review. In that case, the code in review_listing_controller.rb that counts final reviews will include the review for the cancelled session when it shouldn't.

Fixing this bug is as simple as adding a condition joins(:session).where('sessions.state != ?', :cancelled) but need to write some automated tests for it.

@christopher-fredregill
Copy link

Picking this one up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants