You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we discover that sessions need to be cancelled after the review process has already started, there is the possibility that the session to be cancelled already has a review. In that case, the code in review_listing_controller.rb that counts final reviews will include the review for the cancelled session when it shouldn't.
Fixing this bug is as simple as adding a condition joins(:session).where('sessions.state != ?', :cancelled) but need to write some automated tests for it.
The text was updated successfully, but these errors were encountered:
If we discover that sessions need to be cancelled after the review process has already started, there is the possibility that the session to be cancelled already has a review. In that case, the code in review_listing_controller.rb that counts final reviews will include the review for the cancelled session when it shouldn't.
Fixing this bug is as simple as adding a condition
joins(:session).where('sessions.state != ?', :cancelled)
but need to write some automated tests for it.The text was updated successfully, but these errors were encountered: