Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move course YAMLs into a folder? #11

Open
kwinkunks opened this issue Jan 31, 2022 · 5 comments
Open

Move course YAMLs into a folder? #11

kwinkunks opened this issue Jan 31, 2022 · 5 comments
Labels
question Further information is requested

Comments

@kwinkunks
Copy link
Member

Seems like they will probably get out of hand at some point.

@mtb-za
Copy link
Contributor

mtb-za commented Feb 9, 2022

I think that this makes a lot of sense. This could also be something that is flexible? If you are only building one course, it might not make too much sense to have another level of organisation? Certainly for our use-cases we should have them in a subfolder though.

@mtb-za
Copy link
Contributor

mtb-za commented Feb 18, 2022

Been doing some testing, and you can just do something like kosu build courses/my_course.yaml and it seems to work with no issues. This would come down to if we want a pattern like that for users, or if we want it to be able to just use kosu build my_course.yaml. You might be able to just add it to the control file?

The .kosu.yaml needs to be changed to point at the new location for kosu build --all to work, logically enough.

The other downside is that you get a courses folder inside the build folder, and the zip files are placed inside the courses folder. I do not have strong feelings on this, but it is worth documenting that it does work at least.

@kwinkunks
Copy link
Member Author

That's good to know, thanks. I think if we do it, then course_dir should be an option in .kosu.yaml, and should be '.' by default. Then it's clear where things should be and we can keep it tidy so there's no extra dir in the build directory, for example.

Aside: I suppose one could use folders to nest courses arbitrarily... so we at Agile might have a folder of machine learning classes, for example. I think that could be useful, although we'd then need some sort of name-appending syntax like machine-learning--geocomp-mlto avoid creating courses with the same name, which seems like it could get nasty to read and confusing to manage. Maybe the multi-folder thing is a bad idea... Let's park that thought until we actually need it.

@mtb-za
Copy link
Contributor

mtb-za commented Feb 22, 2022

That seems like a reasonably quick change. I will look at what I can do to make that happen.

@kwinkunks
Copy link
Member Author

Take a look at what other paths should be parameters too - eg the names of some of the other directories, especially prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants