Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When follow instruction by kubectl apply team-example.yaml , no staging namespace has automatically created #15

Open
oz4899 opened this issue Apr 11, 2020 · 5 comments
Labels
question Further information is requested

Comments

@oz4899
Copy link

oz4899 commented Apr 11, 2020

When try to follow the instruction based on minikube platform.

After setting up everything and follow each step exactly

once run

kubectl apply -f https://raw.githubusercontent.com/agoda-com/samsahai-example/master/configs/crds/team-example.yaml

no s2h-example namespace has been automatically created as description so, I cannot continue explore this project. please suggest what i'm missing

Thanks,
oz

@oz4899 oz4899 added the question Further information is requested label Apr 11, 2020
@Pohfy123
Copy link
Collaborator

@oz4899 Thank you for your interest in our project.

There are a few steps missing. It requires a secret and configuration for the team.
We already updated the team resource to not require a secret.

Please re-apply team-example.yaml and run the following command

kubectl apply -f https://raw.githubusercontent.com/agoda-com/samsahai-example/master/configs/crds/config-example.yaml

to install config of example team.

We will update the document. Please kindly tell us if you have any problems. 😄

@oz4899
Copy link
Author

oz4899 commented Apr 11, 2020

@Pohfy123 thx for very prompt reply, I did follow the step you mentioned and now s2h-example namespace has been created :) but I think it has small issue regarding the tag of staging-ctrl image that it need to pull from quay.io

image

seems like it should be v1.1.3 instead of just 1.1.3
image

@Pohfy123
Copy link
Collaborator

Pohfy123 commented Apr 11, 2020

@oz4899 I've just created issue #16

There is a workaround solution by overriding the image for staging-ctrl so that you still can continue.
Please run this command to re-apply team

kubectl apply -f https://raw.githubusercontent.com/agoda-com/samsahai-example/master/configs/crds/workarounds/team-example.yaml

We will get back to you once it's fixed.
Sorry for the inconvenience.

@oz4899
Copy link
Author

oz4899 commented Apr 11, 2020

thx a lot

@Pohfy123
Copy link
Collaborator

The fix was merged and released with v1.1.4, please try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants