Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Research compatibility with RFC 6874 and cover it with tests #998

Open
1 task done
webknjaz opened this issue Feb 26, 2024 · 0 comments
Open
1 task done
Labels
bug enhancement Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ help wanted

Comments

@webknjaz
Copy link
Member

Describe the bug

I recently faced missing support for IPv6 URLs with scoped Zone ID suffixes in modern web-browsers. Apparently, they're pointing fingers to each other being unable to decide who should implement/formalize it first (https://ungleich.ch/u/blog/ipv6-link-local-support-in-browsers/).
But there's RFC 6874 that seems to be accepted (although some places on the internet label it as a "proposed standard"). Still, this is something that many libs look up to so we should too. That standard insists on the separator being a URL-encoded %25 (while a point was made for supporting unencoded % for backwards compatibility: urllib3/urllib3#1641 (comment)).

I briefly checked yarl's code and it seems to me that %25 is never supported (strings are partitioned by "%"). There are no test cases that specify the expectations explicitly. We should introduce those and make sure the implementation is consistent with the standard.

To Reproduce

Research needed. I'm just documenting this as a "TODO".

Expected behavior

The behavior should be aligned with urllib3/urllib3#1641 and popular implementations outside the Python ecosystem, like cURL.

Logs/tracebacks

N/A

Python Version

N/A

multidict Version

N/A

yarl Version

N/A

OS

N/A

Additional context

https://datatracker.ietf.org/doc/html/rfc6874

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct
@webknjaz webknjaz added bug enhancement help wanted Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ help wanted
Projects
None yet
Development

No branches or pull requests

1 participant