Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors from start command are discarded causing panics or misleading output #675

Open
istyf opened this issue Nov 2, 2024 · 0 comments · May be fixed by #676
Open

Errors from start command are discarded causing panics or misleading output #675

istyf opened this issue Nov 2, 2024 · 0 comments · May be fixed by #676

Comments

@istyf
Copy link

istyf commented Nov 2, 2024

When runBin calls startCmd to start the newly built application, it discards any returned error and proceeds.

On linux this renders misleading output that the process was started even though it wasn't, but on unix/mac and windows the returned cmd is nil (it probably should be on linux as well) causing a panic when air tries to dereference its pid.

@istyf istyf linked a pull request Nov 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant