Quickbooks source: Refresh token expires after 1 hour in Cloud

[natikgadzhi]

Connector Name

source-quickbooks

❓ What

The Quickbooks connector fails after the refresh token expires, as the refresh token expires after 1 hour.

📈 Impact

Quickbook syncs will be able to continue running without failures. Users often see the second sync and every sync after fail.

🤝 Proposed solution

Rework the authentication for the Quickbook OAuth so that it refreshes the expiry of the token. A refresh token can last up to 100 days.

[natikgadzhi]

This one is pretty high leverage. Let's make sure to implement token refresh mechanism. You will need test accounts though, we'd need to figure out a partner to give us their creds.

[csphereholdings]

Hey there, @natikgadzhi - happy to share some test creds in QB with you. Nothing sensitive there.

[pabloescoder]

Hey @csphereholdings, I'll be working on the issues you posted for QuickBooks - this one and the issue that you're getting about the eval method.

Could you please share the test QB credentials with me?
Or alternatively if you prefer you can share it with @natikgadzhi and I can get those from him, anything works.

[csphereholdings]

Hello @pabloescoder aka Dhroov ;)

Just e-mailed you.

Cheers!

[csphereholdings]

Hello! @pabloescoder just wanted to check in and see how things are coming along? Anything I can help with?

[pabloescoder]

Hey hey @csphereholdings
I've created a PR for the QuickBooks error that you were getting while setting up the connector (str has no method eval) I've resolved that, and while I was testing that I noticed that the token was being refreshed automatically (I was able to get results with an access token that I had created the previous day - so Airbyte was using the refresh token to generate a new access token)
Anyway, we've kicked off regression tests for that connector, and I'm waiting for that PR to get merged, once that's done we can see if the issue with the token is resolved, if not then I'll look into why that's the case.
CC: @natikgadzhi

[csphereholdings]

Awesome! Thanks so much! If I can do anything, please do reach out! Christian M. Grupp CEO Mobile: (307) 203.3008 | Email: ***@***.*** Sphere Holdings, 2810 N Church St PMB 36678, Wilmington, DE 19802 www.<http://www.my-company.com/>sphereholdings.co [signatureImage]

…

________________________________ From: Dhroov Makwana ***@***.***> Sent: Tuesday, August 27, 2024 8:46:59 PM To: airbytehq/airbyte ***@***.***> Cc: Christian Grupp ***@***.***>; Mention ***@***.***> Subject: Re: [airbytehq/airbyte] Quickbooks source: Refresh token expires after 1 hour in Cloud (Issue #44471) Hey hey @csphereholdings<https://github.com/csphereholdings> I've created a PR<#44560> for the QuickBooks error that you were getting while setting up the connector (str has no method eval) I've resolved that, and while I was testing that I noticed that the token was being refreshed automatically (I was able to get results with an access token that I had created the previous day - so Airbyte was using the refresh token to generate a new access token) Anyway, we've kicked off regression tests for that connector, and I'm waiting for that PR to get merged, once that's done we can see if the issue with the token is resolved, if not then I'll look into why that's the case. CC: @natikgadzhi<https://github.com/natikgadzhi> — Reply to this email directly, view it on GitHub<#44471 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BIJ4HBI5PA5JIQMJJSGCZHLZTUMYHAVCNFSM6AAAAABM2SPLQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJTHA3TANBVG4>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[pabloescoder]

Sure, will do, thank you!

[charles-astrafy]

What's the status on this issue ? The connector is a bit useless if the refresh token mechanism is not working.

Thank you.

[csphereholdings]

Greetings! Any updates here? Anything we can do to help close this out?

[pabloescoder]

@charles-astrafy @csphereholdings We've released a new version (3.0.26) that fixes a bug that made the connector unusable.
Are you seeing this issue again in 3.0.26?

[charles-astrafy]

@pabloescoder I confirm the refresh token mechanism is now working on our end. Thanks a lot.

[pabloescoder]

@charles-astrafy Awesome! I'm glad to hear that.
Closing issue as resolved in 3.0.26.

[nataliekwong]

Hi @pabloescoder , I noticed a new similar issue about the authentication expiring after 1 hour: #49842. Would this issue be similar to the one you resolved or different?

Thanks,
Natalie

[pabloescoder]

Hey @nataliekwong, This issue should've been resolved in 3.0.26, but I can see that in the new issue that's raised, they're already on 3.0.26 and still seeing the issue.

The refresh token mechanism was working for me locally and also for Charles as mentioned above.

I'll investigate further to see why we're seeing this issue again.

[nataliekwong]

Got it, thanks!