From a8cb5631b4c3ca6d03805282d4ac46bf451c927a Mon Sep 17 00:00:00 2001 From: grandizzy Date: Fri, 22 Dec 2023 10:53:24 +0200 Subject: [PATCH] Fix slither for external libraries, remove unused IERC20Token.transfer* functions to fix https://github.com/crytic/slither/wiki/Detector-Documentation#incorrect-erc20-interface warning --- .github/workflows/slither.yml | 2 +- src/interfaces/pool/IPool.sol | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/slither.yml b/.github/workflows/slither.yml index 5d1139567..d6fcb869d 100644 --- a/.github/workflows/slither.yml +++ b/.github/workflows/slither.yml @@ -51,7 +51,7 @@ jobs: - name: Analyze Libraries run: | - slither src/libraries/external/. + slither src/libraries/external/ continue-on-error: true id: libraries-analyzer diff --git a/src/interfaces/pool/IPool.sol b/src/interfaces/pool/IPool.sol index 7cb8c6c66..3d7d12ba9 100644 --- a/src/interfaces/pool/IPool.sol +++ b/src/interfaces/pool/IPool.sol @@ -44,12 +44,6 @@ interface IERC20Token { function balanceOf(address account) external view returns (uint256); function burn(uint256 amount) external; function decimals() external view returns (uint8); - function transfer(address to, uint256 amount) external returns (bool); - function transferFrom( - address from, - address to, - uint256 amount - ) external returns (bool); } /// @dev `ERC721` token interface.