Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make public JournalSettings #788

Open
umbreak opened this issue Jun 3, 2020 · 1 comment
Open

Make public JournalSettings #788

umbreak opened this issue Jun 3, 2020 · 1 comment
Labels
0 - new Ticket is unclear on it's purpose or if it is valid or not

Comments

@umbreak
Copy link

umbreak commented Jun 3, 2020

Migrating from 0.100 to 1.0.0 we noticed that CassandraPluginConfig was changed in favour of JournalSettings. We were using CassandraPluginConfig to create/reuse a CassandraSession with the same configuration as the cassandra plugin. Also to reuse keyspace and other configuration flags (autocreate, for instance).

If JournalSettings would be public, we could keep doing it the same way. For now, I had to copy paste some code from that class.

How we were doing it using 0.100: https://github.com/BlueBrain/nexus/blob/ab784387d68a8fccba1da1806b5c2369cfb957cb/sourcing/projections/src/main/scala/ch/epfl/bluebrain/nexus/sourcing/projections/Projections.scala#L82

How we had to do it using 1.0.0: https://github.com/BlueBrain/nexus/blob/1.4.0_iam_refactored/sourcing/projections/src/main/scala/ch/epfl/bluebrain/nexus/sourcing/projections/Projections.scala#L82

Thanks

@patriknw
Copy link
Member

patriknw commented Jun 8, 2020

From 1.0.0 we wanted to minimize the public api surface.

Note that the CassandraSession can be shared via the CassandraSessionRegistry.

@chbatey chbatey added the 0 - new Ticket is unclear on it's purpose or if it is valid or not label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new Ticket is unclear on it's purpose or if it is valid or not
Projects
None yet
Development

No branches or pull requests

3 participants