Akmal / feat: add main trade type page #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
⏳ Generating Lighthouse report... |
kate-deriv
reviewed
Aug 5, 2024
packages/trader/src/AppV2/Components/TradeTypeList/__tests__/trade-type-list-item.spec.tsx
Outdated
Show resolved
Hide resolved
kate-deriv
reviewed
Aug 5, 2024
packages/trader/src/AppV2/Components/TradeTypeList/trade-type-list.tsx
Outdated
Show resolved
Hide resolved
kate-deriv
reviewed
Aug 5, 2024
kate-deriv
reviewed
Aug 5, 2024
kate-deriv
reviewed
Aug 5, 2024
maryia-deriv
reviewed
Aug 5, 2024
packages/trader/src/AppV2/Containers/Trade/__tests__/trade-types.spec.tsx
Show resolved
Hide resolved
maryia-deriv
reviewed
Aug 5, 2024
maryia-deriv
approved these changes
Aug 6, 2024
kate-deriv
approved these changes
Aug 6, 2024
ahmadtaimoor-deriv
approved these changes
Aug 6, 2024
akmal-deriv
pushed a commit
that referenced
this pull request
Oct 7, 2024
* feat: incorporated POA dropdown field * chore: fixed the POA dropdown * fix: type issues in TS * fix: testcase for File upload * chore: incorporated Mobile layout * chore: incorporated POA for mobile * fix: failing testcases * fix: failing testcase in cfd-poa * fix: failing testcase in cfd-poa * chore: added POAForm testcase * chore: added POAForm testcase * fix: incorporated review comments * fix: incorporated new layout changes * fix: incorporated validation for Document type field * fix: incorporated validation for Document type field * likhith/trah-4188/incorporate POA enhancement for wallet (#75) * chore: incorporated POA enhancement in Desktop for wallet * chore: incorporated POA changes in mobile * fix: incorporated review comments * fix: remove comment * Merge remote-tracking branch 'origin/likhith/TRAH-3856/add-poa-document-type' into likhith/TRAH-4188/handle-poa-enhancement-in-wallets * fix: failing testcase * fix: overirde CSS * fix: incorporated review comments * fix: incoprorated review comments * chore: added POA others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
[Please provide a summary of the change.](feat: add main trade type page)
Screenshots:
Please provide some screenshots of the change.