Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not used classes #43

Open
dve opened this issue Jan 23, 2017 · 1 comment
Open

Remove not used classes #43

dve opened this issue Jan 23, 2017 · 1 comment

Comments

@dve
Copy link
Contributor

dve commented Jan 23, 2017

Vaadinator creates tow classes BussinesException and TechnicalException but does not use them. I don't think we should generate not used code and let it to the user to build an exception hierarchy.
@sebastianrothbucher
Copy link
Contributor

with you there ;-)

sebastianrothbucher added a commit that referenced this issue Feb 9, 2017
@sebastianrothbucher
Merge pull request #45 from dve/#43_remove_not_used_classes
c0ce49f 
#43 remove not used classes (LGTM)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dve @sebastianrothbucher