Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move static stuff from templates to dependency #44

Open
dve opened this issue Jan 23, 2017 · 1 comment
Open

Move static stuff from templates to dependency #44

dve opened this issue Jan 23, 2017 · 1 comment

Comments

@dve
Copy link
Contributor

dve commented Jan 23, 2017

We have some classes where we use the templates just to copy code, without modifications (except the package) and we have the VaadinatorUtils maven module where we only have the AbstractPlainJpa class.
Should we not move the static stuff also into this module? This would make it easier to split up a project into sub-modules which all use the same infrastructure artifacts.

@sebastianrothbucher
Copy link
Contributor

sebastianrothbucher commented Feb 1, 2017

There's times where you need the package (like widgetset compilation). So far, those templates w/ only seem like KISS - providing an overall simple codebase (widgetset def, base presenter, ...). Or can you point to an example where it's really unnec? Still open for suggestions though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants