Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async/await for proper async code #78

Open
albe opened this issue Oct 7, 2019 · 1 comment
Open

Use async/await for proper async code #78

albe opened this issue Oct 7, 2019 · 1 comment
Labels
enhancement P: EventStore Affects the EventStore layer postponed

Comments

@albe
Copy link
Owner

albe commented Oct 7, 2019

Since support for node 6.0 has been ruled out, this is doable without manual promisifying.

@albe albe added enhancement P: EventStore Affects the EventStore layer labels Oct 7, 2019
@albe
Copy link
Owner Author

albe commented May 31, 2020

Benchmarks with both promisified and fs.promise suggest being an order of magnitude slower than current sync calls. Of course those benchmarks are synthetic and in an actual application with a bit of CPU bound logic this will turn around. Still, the synchronous model has some benefits in this specific use case, where guarantees about order of writes and consistency are important.

Needs further investigation and playing around with use-cases.

@albe albe added the postponed label Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement P: EventStore Affects the EventStore layer postponed
Projects
None yet
Development

No branches or pull requests

1 participant