Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation behind a corporate proxy fails due to the download of a .tar.gz archive #147

Open
hoh opened this issue Jul 6, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@hoh
Copy link
Member

hoh commented Jul 6, 2023

Describe the bug

Proxies in corporations block many behaviors, including the download of the NodeJS headers file in the screenshot below.

aleph-ts-sdk-download-issue

To Reproduce

Go to a bank or a big corporation ?

Expected behavior

The user can install a version of the library that does not require the download of NodeJS headers.

Environment

Waiting for more details from users...

@hoh hoh added the bug Something isn't working label Jul 6, 2023
@BjrInt
Copy link
Member

BjrInt commented Jul 6, 2023

For context, these are the official C header files for common libs (eg: OpenSSL, libUV, ...) you can see they are downloaded from the official Node.js website.

With no way to reproduce the error on my end, these are the possible solution I can envision:

  • Whitelist the node.js domain inside of the Proxy
  • Manually download the header files, then link them locally and ask not to download them when running npm install, see this stackoverflow post for more insights
  • This is the least preferable option if all of the above fails, fork the repository and get rid of everything Ledger related, these are:
    • The Ledger provider directory and all references pointing to it (imports/exports)
    • The @ledger-live scoped packages in the package.json (L75 to 77) then deleting the package-lock.json and try to run npm install in order to have a fresh install.

Please note that some other packages may need those bindings (at least the OpenSSL cryptographic primitives), so the last option might not even work in this case.

In the meantime we have planned to rewrite this package as a scoped monorepo with multiple packages, which could help with those issues, but I cannot give an exact ETA for this feature

@hoh
Copy link
Member Author

hoh commented Jul 7, 2023

A similar issue has been reported on the NodeJS repository: nodejs/docker-node#198

@MHHukiewitz MHHukiewitz assigned MHHukiewitz and unassigned BjrInt Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants