Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need more control over the capture #46

Open
KaveeHana opened this issue Jan 10, 2021 · 3 comments
Open

Need more control over the capture #46

KaveeHana opened this issue Jan 10, 2021 · 3 comments
Assignees
Labels

Comments

@KaveeHana
Copy link

Save-as-ebook is good at capturing everything in the page indiscriminately, which is useful because capturing everything is better than not capturing the needed part of the page. But this also makes it necessary to clean the generated epub of the unnecessary details afterwards.

Adding the ability to apply regular expression replacements on the capture, based on some site rules would significantly if not completely reduce the need to separately clean the epub afterwards.

Also as I mentioned before it would also help editing the epub if the names of the files inside the created epub are human readable.

@alexadam
Copy link
Owner

alexadam commented Aug 4, 2021

regex or css filters are too messy not not user friendly. we need a better way to clean the page before generating the ebook.

@KaveeHana KaveeHana changed the title Add support for applying regular expression replacements on the captured text Need more control over the capture Aug 7, 2021
@KaveeHana
Copy link
Author

Ok forget about the regex replacements. A method to select the html nodes for capture would do just fine. Even though this extension is more convenient because it's a standalone I mostly use grabmybooks because it gives more control over the capture and the captured html code looks a lot cleaner.

@bunglegrind
Copy link

bunglegrind commented Aug 9, 2021

you can remove the nodes you don't want using the custom CSS rules setting display to none!important. consider what I've written in the first post of issue #50, for instance

@alexadam alexadam self-assigned this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants