Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table borders are not present in the ePub #51

Open
bunglegrind opened this issue Aug 7, 2021 · 2 comments
Open

Table borders are not present in the ePub #51

bunglegrind opened this issue Aug 7, 2021 · 2 comments
Assignees
Labels

Comments

@bunglegrind
Copy link

Similar to #50, borders are not present in the tables (and I suppose in every other place).

Save the following page:

https://dev.mysql.com/doc/refman/8.0/en/innodb-locking.html

with the custom CSS rules:

header,
#docs-sidebar-toc,
#docs-version-nav,
#docs-breadcrumbs,
#docs-in-page-nav-container,
footer
{
  display: none!important;
}

.has-toc {
  margin-left: 0!important;
  border-left: none!important;
}

and check the borders of the first table.
I'm using Firefox on Windows, I haven't tested on Chrome.
The reason is the "border" property: in Firefox it's an empty string and when you grab its content in

let cssValue = $pre.css(cssTagName);

you get nothing.

I've locally fixed the issue by changing the content of the supportedCss array in

var supportedCss = [


const supportedCss = [
    'background-color',
    'border-top-width',
    'border-top-style',
    'border-top-color',
    'border-bottom-width',
    'border-bottom-style',
    'border-bottom-color',
    'border-left-width',
    'border-left-style',
    'border-left-color',
    'border-right-width',
    'border-right-style',
    'border-right-color',
    'border-collapse',
    'color',
    'font',
    'line-height',
    'list-style',
    'padding',
    'text-align',
    'display'
];
@bunglegrind
Copy link
Author

well, that's the same for padding

@bunglegrind
Copy link
Author

...and font

bunglegrind added a commit to bunglegrind/save-as-ebook that referenced this issue Oct 1, 2021
bunglegrind added a commit to bunglegrind/save-as-ebook that referenced this issue Dec 26, 2021
@alexadam alexadam self-assigned this Apr 14, 2023
@alexadam alexadam added the bug label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants