Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desc field of a state being implemented as optional while mandatory in the spec #54

Closed
CiottiGiorgio opened this issue Aug 18, 2023 · 2 comments
Closed

Desc field of a state being implemented as optional while mandatory in the spec #54

CiottiGiorgio opened this issue Aug 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@CiottiGiorgio
Copy link
Member

CiottiGiorgio commented Aug 18, 2023 •
edited
Loading

In addition, it should be desc and not descr
https://github.com/algorandfoundation/ARCs/blob/main/ARCs/arc-0032.md#schema-specification

algokit-client-generator-ts/src/schema/application.d.ts

Line 165 in 2de43ed

descr?: string;

algokit-client-generator-ts/src/schema/application.d.ts

Line 179 in 2de43ed

descr?: string;

@robdmoore robdmoore added the enhancement New feature or request label Dec 29, 2023
@neilcampbell
Copy link
Contributor

@CiottiGiorgio Just checking in on this one.
The ARC was updated a few months ago and matches the code correctly now.
I believe I can close this issue now, however just wanted to confirm.

@CiottiGiorgio
Copy link
Member Author

Very nice. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robdmoore @neilcampbell @CiottiGiorgio