chore: adding peer dependency with algosdk #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcampbell
approved these changes
Aug 22, 2023
|
I think this is probaby a breaking change? Should we add that in so major version gets bumped? |
|
@robdmoore Yep, we were chatting through update scenarios after standup today and realised it likely should be a major version bump. Was just about to type a message to confirm our thinking made sense. |
|
Also, let's pin it to the latest algosdk - |
|
@robdmoore if we pin to that specific version, we will be forcing consumers to use that exact version in their projects. Assuming you're simply suggesting we update the package.json to |
|
Yep! |
negar-abbasi
pushed a commit
that referenced
this pull request
Aug 31, 2023
Fixing some lint warnings Trigger a major version bump for the previous merged PR chore: adding peer dependency with algosdk #107 BREAKING CHANGES: The previous merged PR (commit 80d501f) introduced some breaking changes, however semantic release didn't detect as a breaking change, as the commit wasn't formatted correctly.
negar-abbasi
pushed a commit
that referenced
this pull request
Aug 31, 2023
Bumps [@tsconfig/node16](https://github.com/tsconfig/bases/tree/HEAD/bases) from 16.1.0 to 16.1.1. Trigger a major version bump for a previous merged PR chore: adding peer dependency with algosdk #107 BREAKING CHANGE: A previous merged PR (commit 80d501f) introduced some breaking changes, however semantic release didn't detect as a breaking change, as the commit wasn't formatted correctly.
negar-abbasi
pushed a commit
that referenced
this pull request
Aug 31, 2023
…sing getAccount (#120) feat: Added algokit.mnemonicAccountFromEnvironment to deprecate confusing getAccount Trigger a major version bump for a previous merged PR chore: adding peer dependency with algosdk #107 BREAKING CHANGE: A previous merged PR (commit 80d501f) introduced some breaking changes, however semantic release didn't detect as a breaking change, as the commit wasn't formatted correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.