Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clearml] Allow annotations for service account for apiserver #330

Open
aaj-synth opened this issue Oct 7, 2024 · 3 comments
Open

[clearml] Allow annotations for service account for apiserver #330

aaj-synth opened this issue Oct 7, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@aaj-synth
Copy link

aaj-synth commented Oct 7, 2024

Is your feature request related to a problem ?

As per storage documentation, we want to configure clearml server to write artifacts to S3 bucket on AWS, but currently that is not possible.

Describe the solution you'd like.

A solution would require apiserver pod to either have custom service account provided by the user which would allow the pod to access the S3 bucket, or allow the service account template to configure additional annotations to allow pod to access the S3 bucket. Helm chart values file would look something like this:

apiserver:
  existingServiceAccountName: ""
  serviceAccountName: ""
  serviceAccountAnnotations: {}

Describe alternatives you've considered.

Currently the way to make it work is to create a role in AWS which has the necessary permissions, and attach the annotations on the serviceAccount to allow it to access S3 bucket. This is far from ideal and creates lots of duplicated code and tech-debt

Additional context.

I am currently using helm chart version 7.11.4

@aaj-synth aaj-synth added the enhancement New feature or request label Oct 7, 2024
@aaj-synth
Copy link
Author

@filippo-clearml any updates on this one?

@filippo-clearml
Copy link
Collaborator

@aaj-synth You should already be able to edit serviceAccountName to use an existing custom service account, is this working for you?
Anyway being able to add custom annotations and labels is a good idea, we'll work on that :)

@aaj-synth
Copy link
Author

Yes, that edit part is working but takes away a lot of deployment power, as someone has to jump in and do the trick for the system to work, and ofcourse have to restart the apiserver so that the pod picks up the correct role from the serviceaccount.

Indeed that would be great to have, and another thing which would be really nice to have is to allow user to bring in their own serviceaccount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants