fix(onNext)!: stop calling onNext in componentDidMount #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING_CHANGE: onNext will no longer be called within Wizard's componentDidMount
closes #33
Description
onNext
is called withincomponentDidMount
insideWizard
. This is confusing because no action has been taken at this point andnext
has not been called yet.Motivation and Context
onNext
being called insidecomponentDidMount
is confusing for developers #33. Additionally, on initial render, you don't have the steps date or current step id to make a decision about where you might want to go.How Has This Been Tested?
a unit test was updated to ensure
onNext
isn't called on renderTypes of Changes
Checklist:
What is the Impact to Developers Using react-albus?
if they previously depended on
onNext
being called on initial render, it won't get called any more.