Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove magic #72

Open
amitu opened this issue Sep 2, 2015 · 4 comments
Open

remove magic #72

amitu opened this issue Sep 2, 2015 · 4 comments

Comments

@amitu
Copy link
Owner

amitu commented Sep 2, 2015

We have a bunch of thing that works, and a bunch of thing that kind of does not. For 1.0 release lets remove all magic.

What is importd?

Its a way to django projects, with less fuss. It has a settings framework, and it encourages sane and useful configuration for teams, like using envdir.

What we should keep

  • @d("/") decorator for views
  • settings framework
  • single file setup.
  • dj_database_url
  • smart return (how to do this without auto adjusting middlewares?)
  • auto wsgi setup
  • auto APP_DIR (call it PROJ_DIR?) and d.dotslash()
  • secret.txt support (optionally read it from ENV?)
  • auto set template dirs
  • auto set static dir
  • auto set DATABASES
  • auto set TEMPLATE_DEBUG to DEBUG
  • auto set MANAGERS to ADMINS
  • auto import .views and .admin etc for each app

What we should discard

  • modifying INSTALLED_APPS etc beyond what is done by settings framework (debug: and prod: prefix handling)
  • auto configuration of admin
  • werkzeug, django_jinja, django_extensions
  • d.get_object_or_404 etc (i have never used them personally)

Lets also deprecate < 1.8 in 1.0 release so we have less mess.

@ghost
Copy link

ghost commented Sep 2, 2015

Nice ideas Amitu ❕

I been thinking of secret.txt support (optionally read it from ENV?),

I think that should be a JSON file, because we all know how the structure of a JSON file is without reading any specific Documentation, but when people see a *.txt you dont know what to put there ❔

To read from ENV should be a nice addition, but put passwords on ENV is widely used ❔

Lets also deprecate < 1.8 in 1.0 release so we have less mess. Im so happy with this ❕

Have you seen that Coffin becomes only a pair of template tags since Django now supports Jinja2,
so I suggest removing Coffin integration by default, since Coffin itself recommends doing so, or at least explain what I said.

I would say try to improve and update the Documentation ❔

Upload the new version to PyPI of course ❕

:octocat:

juancarlospaco added a commit that referenced this issue Feb 1, 2016
@ghost
Copy link

ghost commented Feb 1, 2016

  • Some of this changes are now on Master.
  • All Tests passing, if you run it manually, even if Travis CI gets confused with Python2/Python3.
  • Secret Key improved, optionally read it from ENV.
  • werkzeug, django_jinja, django_extensions, coffin, etc etc all Clean Up.
  • Working with Django 1.9

😸

@amitu
Copy link
Owner Author

amitu commented Feb 1, 2016

Nice work man :-) Looking forward to rest of it :-)

@ghost
Copy link

ghost commented Feb 6, 2016

With modern Djangos:

  • d.models is broken.
  • /admin/ is broken.
  • django-debug-toolbar is broken.
  • django-debug-toolbar itself seems unmaintained(?).
  • fhurl is broken.
  • I want to drop mandatory fhurl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant