Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What libpll code is really needed #164

Open
tillea opened this issue Aug 17, 2023 · 3 comments
Open

What libpll code is really needed #164

tillea opened this issue Aug 17, 2023 · 3 comments

Comments

@tillea
Copy link

tillea commented Aug 17, 2023

Hi,
since years I'd like to package raxml-ng for Debian. Unfortunately it remains unclear to me, what libpll is needed. I have packaged [libpll](https://github.com/xflouris/libpll] which is mentioned in README.md but it does not contain the file libpll/pllmod_common.h which is included. I find this one in pll-modules and this in turn includes the submodule libpll-2 which does not seem to be some successor of libpll. In Debian we can't rely on submodules but need to package different software in different packages. Am I correct that I need to package libpll-2 first to get pll-modules packaged which I can finally use to build a raxml-ng package?
It would be great if you could adapt README.md with more precise advise.
Kind regards, Andreas.

@amkozlov
Copy link
Owner

Hi Andreas,

sorry for the mess!

Indeed, in order to to compile raxml-ng, you actually need both pll-modules and libpll-2 (which is a successor of libpll).

I just added a hint to the README about submodule dependencies:

https://github.com/amkozlov/raxml-ng/tree/master#installation-instructions

I also added information about libpll-2/pll-modules versions to the raxml-ng release notes:

https://github.com/amkozlov/raxml-ng/releases/tag/1.2.0

Hope this helps.

@tillea
Copy link
Author

tillea commented Aug 18, 2023 via email

@amkozlov
Copy link
Owner

If I simply would package libpll-2 in the very place where libpll was packaged and I keep that name (without the -2) this would be pretty convenient since its not a new Debian package and does not need any new processing. Do you think this is the correct way to go?

Yes, I think this is the way to go.

In fact, in the next major raxml-ng release, both libpll-2 and pll-modules will be superseded by the new lib coraxlib:

https://codeberg.org/Exelixis-Lab/coraxlib

This should hopefully solve the long-lasting historical name confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants