Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prefect linting care about lint levels #112

Open
danpetry opened this issue Oct 25, 2022 · 4 comments
Open

Make prefect linting care about lint levels #112

danpetry opened this issue Oct 25, 2022 · 4 comments

Comments

@danpetry
Copy link
Member

i.e., it shouldn't fail on ERROR, WARNING, and INFO. Definitely on ERROR, and maybe on WARNING too.

It may be helpful also to define more clearly what type of lints go in which of these categories.

@marcoesters
Copy link
Collaborator

I think INFO should never result in a failure. WARNING is fine, or we could leave it up to the discretion of the reviewers to determine if that warning is worth blocking the PR.

@danpetry
Copy link
Member Author

this makes sense to me: ERROR is a hard fail which doesn't require any other interpretation, and WARNING requires some interpretation to determine how serious it is.
Something like this: https://gcc.gnu.org/onlinedocs/gcc-5.1.0/gcc/Warnings-and-Errors.html

@marcoesters
Copy link
Collaborator

This should help with the implementation: #120

@schuylermartin45
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants