Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation script: Support checksum signature verification #1627

Closed
hibare opened this issue Dec 5, 2023 · 2 comments · Fixed by #1670
Closed

Installation script: Support checksum signature verification #1627

hibare opened this issue Dec 5, 2023 · 2 comments · Fixed by #1670
Labels
enhancement New feature or request

Comments

@hibare
Copy link
Contributor

hibare commented Dec 5, 2023

What would you like to be added:

Grype simplifies the installation process through a convenient script. The current script includes a checksum validation step for the binary being installed. Since Grype utilizes cosign to sign the checksum file, it would be beneficial to enhance the installation script by incorporating checksum signature validation.

Why is this needed:

This enhancement ensures consumers can effortlessly verify the installation of binaries, eliminating the need for manual verification.

Additional context:

@hibare hibare added the enhancement New feature or request label Dec 5, 2023
@tgerla
Copy link
Contributor

tgerla commented Dec 14, 2023

Hi @hibare, thank you for the suggestion! I think we would be open to this feature in the install script, especially if it were triggered by a command line flag. We are hesitant to make our installation script rely on a 3rd party program (cosign), but if it were an optional parameter I think that would be fine. Is this something you'd be interested in working on? We'd be happy to help.

@tgerla tgerla moved this to Backlog in OSS Dec 14, 2023
@hibare
Copy link
Contributor Author

hibare commented Dec 18, 2023

Hello @tgerla Yes, it'll be an optional parameter to the installation script. I'll be submitting a pull request in the coming days.

@wagoodman wagoodman changed the title Installation script: Support automatic checksum signature verification Installation script: Support checksum signature verification Jun 6, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in OSS Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants