Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid global definiton of module by using angular's chaining syntax #5

Open
szabyg opened this issue May 21, 2015 · 0 comments · May be fixed by #6
Open

Avoid global definiton of module by using angular's chaining syntax #5

szabyg opened this issue May 21, 2015 · 0 comments · May be fixed by #6

Comments

@szabyg
Copy link

szabyg commented May 21, 2015

Defining var module in the window scope creates a global variable. This should be avoided by using angular's chaining syntax.
Pull request follows.
szabyg added a commit to Eurofunk/ngPopover that referenced this issue May 21, 2015
@szabyg
[Fix] Use chaining syntax. Fixes anderslarsson#5
8715c5d
szabyg added a commit to Eurofunk/ngPopover that referenced this issue May 21, 2015
@szabyg
[Fix] Use chaining syntax. Fixes anderslarsson#5
69b466e
@szabyg szabyg linked a pull request May 21, 2015 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Use chaining syntax. Fixes #5 Eurofunk/ngPopover
1 participant
@szabyg