Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuclear signal not being size normalized when generating cell table #1171

Open
alex-l-kong opened this issue Oct 30, 2024 · 0 comments · May be fixed by #1173
Open

Nuclear signal not being size normalized when generating cell table #1171

alex-l-kong opened this issue Oct 30, 2024 · 0 comments · May be fixed by #1173
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@alex-l-kong
Copy link
Contributor

alex-l-kong commented Oct 30, 2024

Describe the bug

Humza is running a cohort and will be using the nuclear signal for Pixie analysis. The nuclear signal is not normalized in segmentation_utils.transform_expression_matrix.

The process for size normalization at https://github.com/angelolab/ark-analysis/blob/main/src/ark/segmentation/segmentation_utils.py#L117-L133 only works for whole cell data, since the "cell_size" and "label" columns only contain the whole cell channel expression columns in between, not the corresponding nuclear channel expression columns. Additionally, normalization by whole cell size should only happen for whole cell signal; the function does not support nuclear signal normalization by nuclear area.

Expected behavior

If nuclear signal is run through Pixie, it should be at least size normalized, if not arcsinh normalized on top of that. transform_expression_matrix should account for this so marker_quantification.create_marker_count_matrices doesn't append raw nuclear signal as normalized.

@alex-l-kong alex-l-kong added bug Something isn't working help wanted Extra attention is needed labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant