Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default generated favicon.ico doesn't work -> rename to png works #28645

Open
1 task
hci2 opened this issue Oct 16, 2024 · 2 comments
Open
1 task

Default generated favicon.ico doesn't work -> rename to png works #28645

hci2 opened this issue Oct 16, 2024 · 2 comments

Comments

@hci2
Copy link

hci2 commented Oct 16, 2024

Command

new

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

When scaffolding a new Angular project via ng new <PROJECT_NAME> the generated favicon.ico does not work. I just renamed it to favicon.png and changed the reference in index.html and it works immediately.

How about changing the scaffolding to use PNG instead of *.ico?

Minimal Reproduction

favicon.ico (default after generating via ng create):

Image

favicon.png (after renaming and changing):

Image

Exception or Error

No response

Your Environment

 _                      _                 ____ _     ___
/ \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|

/ △ \ | '_ \ / | | | | |/ _ | '__| | | | | | |
/ ___ | | | | (
| | || | | (| | | | || | | |
// __| ||_, |_,||_,|| _|||
|___/

Angular CLI: 18.2.8
Node: 20.17.0
Package Manager: npm 10.9.0
OS: darwin arm64

Angular: 18.2.8
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.1802.8
@angular-devkit/build-angular 18.2.8
@angular-devkit/core 18.2.8
@angular-devkit/schematics 18.2.8
@schematics/angular 18.2.8
rxjs 7.8.1
typescript 5.5.4
zone.js 0.14.10

Anything else relevant?

IDE: VS Code (1.94.2 (Universal))
Browser: Chrome (129.0.6668.91 (Official Build) (arm64))
OS: MacOS (15.0.1)

@hci2
Copy link
Author

hci2 commented Oct 16, 2024

Moreover, I also noticed that the docs are not up-to-date regarding src/assets and src/favicon.ico, see: https://angular.dev/reference/configs/workspace-config#assets-configuration.

@alan-agius4
Copy link
Collaborator

Hi @hci2,
I couldn't reproduce the issue you've mentioned.

Image

Regarding the documentation issue, please open an issue at https://github.com/angular/angular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants