Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare_apk_size.yml is broken #17109

Closed
Arthur-Milchior opened this issue Sep 22, 2024 · 1 comment
Closed

compare_apk_size.yml is broken #17109

Arthur-Milchior opened this issue Sep 22, 2024 · 1 comment
Assignees

Comments

@Arthur-Milchior
Copy link
Member

The size check failed on https://github.com/ankidroid/Anki-Android/actions/runs/10981548896/job/30488712178 (ankidroid's main) and on a branch of mine https://github.com/Arthur-Milchior/Anki-Android/actions/runs/10981505951

Seems the error are different some how. In ankidroid's main it's

bash: line 1: ./gradlew: No such file or directory
Error: Final attempt failed. Child_process exited with error code 127

In my branch it's

startup failed:
General error during semantic analysis: Unsupported class file major version 65

java.lang.IllegalArgumentException: Unsupported class file major version 65
at groovyjarjarasm.asm.ClassReader.(ClassReader.java:196)
at groovyjarjarasm.asm.ClassReader.(ClassReader.java:177)
at groovyjarjarasm.asm.ClassReader.(ClassReader.java:163)
at groovyjarjarasm.asm.ClassReader.(ClassReader.java:284)

I need to run this to satisfy @david-allison request in #17107 (I expect there would not be any change in apk size, but David is right it's better to check)

@mikehardy
Copy link
Member

I believe this is user error, to run the action correctly:

1- just hit "Actions" at the top of the ankidroid repo
2- select the APK size comparison
3- choose to manually run it
4- specify your PR number in the input box
5- hit go and wait, a comment will pop out on the PR with the old vs new size

Of course this could be better, I have an issue open where I described the design and some technical detail that is feasible to meet the design where this could run every time a PR is built as part of the emulator workflow without really increasing build times anywhere

But I haven't had time to do that yet, I will some day, Open Collective is nearly caught up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants