Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "cURL" to "curl" or "Curl" #23

Open
anlutro opened this issue Jul 14, 2015 · 2 comments
Open

Change "cURL" to "curl" or "Curl" #23

anlutro opened this issue Jul 14, 2015 · 2 comments
Labels
code quality enhancement New feature or request
Milestone

Comments

@anlutro
Copy link
Owner

anlutro commented Jul 14, 2015

Needlessly annoying to type. Obviously a breaking change.

@anlutro anlutro added the enhancement New feature or request label Jul 14, 2015
@anlutro anlutro self-assigned this Jul 14, 2015
@anlutro anlutro added this to the Version 2.0 milestone Jul 14, 2015
@mauvm
Copy link

mauvm commented Jul 27, 2015

Why is this a breaking change? Class names and namespaces are case insensitive. And otherwise you could use use anlutro\cURL\cURL as Curl.

@anlutro
Copy link
Owner Author

anlutro commented Jul 27, 2015

Class names and namespaces are indeed case-insensitive, but composer's autoloader is not.

andreas@oberyn ~/dev/php/test
$ cat composer.json 
{
  "autoload": {
    "psr-4": {
      "Test\\": "src/"
    }
  }
}
andreas@oberyn ~/dev/php/test
$ cat src/Test.php 
<?php
namespace Test;
echo 'loading '.__FILE__."\n";
class Test {}
andreas@oberyn ~/dev/php/test
$ cat test.php 
<?php
require __DIR__.'/vendor/autoload.php';
var_dump(class_exists('test\test'));
var_dump(class_exists('Test\Test'));
andreas@oberyn ~/dev/php/test
$ php test.php 
bool(false)
loading /home/andreas/dev/php/test/src/Test.php
bool(true)

@anlutro anlutro removed their assignment Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants