Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rust-lang/libc for types? #23

Open
mrhota opened this issue Feb 27, 2017 · 5 comments
Open

use rust-lang/libc for types? #23

mrhota opened this issue Feb 27, 2017 · 5 comments

Comments

@mrhota
Copy link
Collaborator

mrhota commented Feb 27, 2017

I thought it'd be nicer to use rust-lang/libc's infrastructure for choosing arch-specific types. I think it's possible to link to rust-lang/libc but not link to system libc. Thoughts?

@anp anp closed this as completed Feb 27, 2017
@anp anp reopened this Feb 27, 2017
@anp
Copy link
Owner

anp commented Feb 27, 2017

Sorry, mobile fat fingers.

I tried this when I first got started, but I can't remember what blocked me. I think it created a cyclic linker issue for symbols that were defined in the same static library, but I can't remember. I frankly can't remember at the moment whether that would even be an issue for the linker :D.

@mrhota
Copy link
Collaborator Author

mrhota commented Feb 27, 2017

It looks like it works now. shrug. libstd and friends don't get linked, tests still pass.

@anp
Copy link
Owner

anp commented Feb 27, 2017

Huzzah! I need to look at the diff b/t the libc crate and the platform module for rusl -- I'll put that on my list soon.

@mrhota
Copy link
Collaborator Author

mrhota commented Feb 28, 2017

@dikaiosune what exactly would you be on the lookout for?

@anp
Copy link
Owner

anp commented Feb 28, 2017

I can't remember exactly, but I seem to recall there being a couple of items that I had to change to get desirable semantics on the Rust side (signedness, maybe?). It's probably fine to just go ahead and switch things over, assuming tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants