-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use rust-lang/libc for types? #23
Comments
Sorry, mobile fat fingers. I tried this when I first got started, but I can't remember what blocked me. I think it created a cyclic linker issue for symbols that were defined in the same static library, but I can't remember. I frankly can't remember at the moment whether that would even be an issue for the linker :D. |
It looks like it works now. shrug. |
Huzzah! I need to look at the diff b/t the libc crate and the platform module for rusl -- I'll put that on my list soon. |
@dikaiosune what exactly would you be on the lookout for? |
I can't remember exactly, but I seem to recall there being a couple of items that I had to change to get desirable semantics on the Rust side (signedness, maybe?). It's probably fine to just go ahead and switch things over, assuming tests pass. |
I thought it'd be nicer to use rust-lang/libc's infrastructure for choosing arch-specific types. I think it's possible to link to rust-lang/libc but not link to system libc. Thoughts?
The text was updated successfully, but these errors were encountered: