Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible lint - fix integration tests in order to align with ansible lint policy #671

Open
ronger4 opened this issue Oct 22, 2024 · 1 comment · May be fixed by #672, #673, #674, #675 or #676
Open

Ansible lint - fix integration tests in order to align with ansible lint policy #671

ronger4 opened this issue Oct 22, 2024 · 1 comment · May be fixed by #672, #673, #674, #675 or #676

Comments

@ronger4
Copy link

ronger4 commented Oct 22, 2024

SUMMARY

Currently when running ansible-lint command, there are many comments.
If we consider running ansible-lint as part of the CI in the future, we would like to align with ansible-lint and clean the code in order to get clean results from it.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

We need to run, check and fix ansible-lint warnings coming from all the targets.
For example:
win_acl
win_async
....

ANSIBLE VERSION
ansible [core 2.17.4]
COLLECTION VERSION
2.5.0
OS / ENVIRONMENT
STEPS TO REPRODUCE
No special hardware needed. Will reproduce when ansible-lint runs.
EXPECTED RESULTS

Expected result after running ansible-lint would be:
image

ACTUAL RESULTS

Running ansible-lint from .ansible/collections/ansible_collections/ansible/windows/tests/integration/targets/win_acl :
Finishes the run with the following
image


@ronger4
Copy link
Author

ronger4 commented Oct 22, 2024

This issue is created so we can create small PRs and reference this issue.
Placing all changes in 1 PR for all the targets would be too large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment