Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the hackathon: Improve examples in modules #3354

Closed
1 task done
Andersson007 opened this issue Sep 9, 2021 · 3 comments
Closed
1 task done

For the hackathon: Improve examples in modules #3354

Andersson007 opened this issue Sep 9, 2021 · 3 comments
Labels
docs easyfix Good for new comers and easy to start with contribution

Comments

@Andersson007
Copy link
Contributor

Andersson007 commented Sep 9, 2021

Summary

NOTE: Please don't fix this before the hackathon https://hackmd.io/CqUQNTEqRBCHBTC4WF-9Aw?view. If interested in fixing this, please register for the summit

IMPORTANT: let's create separate PRs for this!

  1. [FIXED] In plugins/modules/remote_management/lenovoxcc/xcc_redfish_command.py in the EXAMPLES block (FIXED fix structure xcc_redfish_command #3479)
 64 - ansible.builtin.debug:
 65   msg: "{{ result.redfish_facts.data }}"

should be changed to something like

 64 - name: Print fetched information
 65   ansible.builtin.debug:
 66     msg: "{{ result.redfish_facts.data }}"

This is the Ansible doc guide requirement.

  1. Same as above for plugins/modules/remote_management/redfish/redfish_info.py (rasdva3 on matrix has PICKED IT UP Update redfish_info.py #3485)

Issue Type

Documentation Report

Component Name

plugins/modules/remote_management/lenovoxcc/xcc_redfish_command.py
plugins/modules/remote_management/redfish/redfish_info.py

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@Andersson007 Andersson007 added docs easyfix Good for new comers and easy to start with contribution labels Sep 9, 2021
@Andersson007
Copy link
Contributor Author

bot_skip

@Andersson007 Andersson007 changed the title For the hackathon: Improve readability of examples in nios_network module For the hackathon: Improve examples modules Sep 9, 2021
@Andersson007 Andersson007 changed the title For the hackathon: Improve examples modules For the hackathon: Improve examples in modules Sep 9, 2021
@Andersson007
Copy link
Contributor Author

FYI rasdva3 on matrix has PICKED IT UP FILE 2.

@Andersson007
Copy link
Contributor Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs easyfix Good for new comers and easy to start with contribution
Projects
None yet
Development

No branches or pull requests

1 participant