From f43549ee76116520ea7bf03fe44ef3d346d7134e Mon Sep 17 00:00:00 2001 From: Vitaly Khabarov Date: Sun, 17 Oct 2021 10:57:09 +0300 Subject: [PATCH 1/5] Add names to tasks in oneview module examples --- .../oneview/oneview_datacenter_info.py | 20 ++++++++--- .../oneview/oneview_enclosure_info.py | 36 ++++++++++++++----- .../oneview/oneview_ethernet_network_info.py | 16 ++++++--- .../oneview/oneview_fc_network_info.py | 10 ++++-- .../oneview/oneview_fcoe_network_info.py | 9 +++-- ...oneview_logical_interconnect_group_info.py | 9 +++-- .../oneview/oneview_network_set_info.py | 17 +++++---- .../oneview/oneview_san_manager_info.py | 9 +++-- 8 files changed, 89 insertions(+), 37 deletions(-) diff --git a/plugins/modules/remote_management/oneview/oneview_datacenter_info.py b/plugins/modules/remote_management/oneview/oneview_datacenter_info.py index 3e5b96376e2..04a8bd922d4 100644 --- a/plugins/modules/remote_management/oneview/oneview_datacenter_info.py +++ b/plugins/modules/remote_management/oneview/oneview_datacenter_info.py @@ -47,7 +47,9 @@ api_version: 500 delegate_to: localhost register: result -- ansible.builtin.debug: + +- name: Print fetched information about Data Centers + ansible.builtin.debug: msg: "{{ result.datacenters }}" - name: Gather paginated, filtered and sorted information about Data Centers @@ -62,7 +64,9 @@ sort: 'name:descending' filter: 'state=Unmanaged' register: result -- ansible.builtin.debug: + +- name: Print fetched information about paginated, filtered and sorted list of Data Centers + ansible.builtin.debug: msg: "{{ result.datacenters }}" - name: Gather information about a Data Center by name @@ -74,7 +78,9 @@ name: "My Data Center" delegate_to: localhost register: result -- ansible.builtin.debug: + +- name: Print fetched information about Data Center found by name + ansible.builtin.debug: msg: "{{ result.datacenters }}" - name: Gather information about the Data Center Visual Content @@ -88,9 +94,13 @@ - visualContent delegate_to: localhost register: result -- ansible.builtin.debug: + +- name: Print fetched information about Data Center found by name + ansible.builtin.debug: msg: "{{ result.datacenters }}" -- ansible.builtin.debug: + +- name: Print fetched information about Data Center Visual Content + ansible.builtin.debug: msg: "{{ result.datacenter_visual_content }}" ''' diff --git a/plugins/modules/remote_management/oneview/oneview_enclosure_info.py b/plugins/modules/remote_management/oneview/oneview_enclosure_info.py index 249fea48742..18e245d617e 100644 --- a/plugins/modules/remote_management/oneview/oneview_enclosure_info.py +++ b/plugins/modules/remote_management/oneview/oneview_enclosure_info.py @@ -50,7 +50,9 @@ no_log: true delegate_to: localhost register: result -- ansible.builtin.debug: + +- name: Print fetched information about Enclosures + ansible.builtin.debug: msg: "{{ result.enclosures }}" - name: Gather paginated, filtered and sorted information about Enclosures @@ -67,7 +69,9 @@ no_log: true delegate_to: localhost register: result -- ansible.builtin.debug: + +- name: Print fetched information about paginated, filtered ans sorted list of Enclosures + ansible.builtin.debug: msg: "{{ result.enclosures }}" - name: Gather information about an Enclosure by name @@ -80,7 +84,9 @@ no_log: true delegate_to: localhost register: result -- ansible.builtin.debug: + +- name: Print fetched information about Enclosure found by name + ansible.builtin.debug: msg: "{{ result.enclosures }}" - name: Gather information about an Enclosure by name with options @@ -97,13 +103,21 @@ no_log: true delegate_to: localhost register: result -- ansible.builtin.debug: + +- name: Print fetched information about Enclosure found by name + ansible.builtin.debug: msg: "{{ result.enclosures }}" -- ansible.builtin.debug: + +- name: Print fetched information about Enclosure Script + ansible.builtin.debug: msg: "{{ result.enclosure_script }}" -- ansible.builtin.debug: + +- name: Print fetched information about Enclosure Environmental Configuration + ansible.builtin.debug: msg: "{{ result.enclosure_environmental_configuration }}" -- ansible.builtin.debug: + +- name: Print fetched information about Enclosure Utilization + ansible.builtin.debug: msg: "{{ result.enclosure_utilization }}" - name: "Gather information about an Enclosure with temperature data at a resolution of one sample per day, between two @@ -125,9 +139,13 @@ no_log: true delegate_to: localhost register: result -- ansible.builtin.debug: + +- name: Print fetched information about Enclosure found by name + ansible.builtin.debug: msg: "{{ result.enclosures }}" -- ansible.builtin.debug: + +- name: Print fetched information about Enclosure Utilization + ansible.builtin.debug: msg: "{{ result.enclosure_utilization }}" ''' diff --git a/plugins/modules/remote_management/oneview/oneview_ethernet_network_info.py b/plugins/modules/remote_management/oneview/oneview_ethernet_network_info.py index 1f25364d3ac..f1b55165b1a 100644 --- a/plugins/modules/remote_management/oneview/oneview_ethernet_network_info.py +++ b/plugins/modules/remote_management/oneview/oneview_ethernet_network_info.py @@ -44,7 +44,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about Ethernet Networks + ansible.builtin.debug: msg: "{{ result.ethernet_networks }}" - name: Gather paginated and filtered information about Ethernet Networks @@ -58,7 +59,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about paginated and filtered list of Ethernet Networks + ansible.builtin.debug: msg: "{{ result.ethernet_networks }}" - name: Gather information about an Ethernet Network by name @@ -68,7 +70,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about Ethernet Network found by name + ansible.builtin.debug: msg: "{{ result.ethernet_networks }}" - name: Gather information about an Ethernet Network by name with options @@ -81,9 +84,12 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about Ethernet Network Associated Profiles + ansible.builtin.debug: msg: "{{ result.enet_associated_profiles }}" -- ansible.builtin.debug: + +- name: Print fetched information about Ethernet Network Associated Uplink Groups + ansible.builtin.debug: msg: "{{ result.enet_associated_uplink_groups }}" ''' diff --git a/plugins/modules/remote_management/oneview/oneview_fc_network_info.py b/plugins/modules/remote_management/oneview/oneview_fc_network_info.py index 4707f39f2dd..40fed8d0177 100644 --- a/plugins/modules/remote_management/oneview/oneview_fc_network_info.py +++ b/plugins/modules/remote_management/oneview/oneview_fc_network_info.py @@ -39,7 +39,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about Fibre Channel Networks + ansible.builtin.debug: msg: "{{ result.fc_networks }}" - name: Gather paginated, filtered and sorted information about Fibre Channel Networks @@ -52,7 +53,9 @@ filter: 'fabricType=FabricAttach' delegate_to: localhost register: result -- ansible.builtin.debug: + +- name: Print fetched information about paginated, filtered and sorted list of Fibre Channel Networks + ansible.builtin.debug: msg: "{{ result.fc_networks }}" - name: Gather information about a Fibre Channel Network by name @@ -62,7 +65,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about Fibre Channel Network found by name + ansible.builtin.debug: msg: "{{ result.fc_networks }}" ''' diff --git a/plugins/modules/remote_management/oneview/oneview_fcoe_network_info.py b/plugins/modules/remote_management/oneview/oneview_fcoe_network_info.py index 6cb3501ddf2..e581bff8625 100644 --- a/plugins/modules/remote_management/oneview/oneview_fcoe_network_info.py +++ b/plugins/modules/remote_management/oneview/oneview_fcoe_network_info.py @@ -38,7 +38,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about FCoE Networks + ansible.builtin.debug: msg: "{{ result.fcoe_networks }}" - name: Gather paginated, filtered and sorted information about FCoE Networks @@ -52,7 +53,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about paginated, filtered and sorted list of FCoE Networks + ansible.builtin.debug: msg: "{{ result.fcoe_networks }}" - name: Gather information about a FCoE Network by name @@ -62,7 +64,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about FCoE Network found by name + ansible.builtin.debug: msg: "{{ result.fcoe_networks }}" ''' diff --git a/plugins/modules/remote_management/oneview/oneview_logical_interconnect_group_info.py b/plugins/modules/remote_management/oneview/oneview_logical_interconnect_group_info.py index 7a0f0dc9877..436dd5d62be 100644 --- a/plugins/modules/remote_management/oneview/oneview_logical_interconnect_group_info.py +++ b/plugins/modules/remote_management/oneview/oneview_logical_interconnect_group_info.py @@ -43,7 +43,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about Logical Interconnect Groups + ansible.builtin.debug: msg: "{{ result.logical_interconnect_groups }}" - name: Gather paginated, filtered and sorted information about Logical Interconnect Groups @@ -61,7 +62,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about paginated, filtered and sorted list of Logical Interconnect Groups + ansible.builtin.debug: msg: "{{ result.logical_interconnect_groups }}" - name: Gather information about a Logical Interconnect Group by name @@ -75,7 +77,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about Logical Interconnect Group found by name + ansible.builtin.debug: msg: "{{ result.logical_interconnect_groups }}" ''' diff --git a/plugins/modules/remote_management/oneview/oneview_network_set_info.py b/plugins/modules/remote_management/oneview/oneview_network_set_info.py index 595d003c56f..2d610f2b57d 100644 --- a/plugins/modules/remote_management/oneview/oneview_network_set_info.py +++ b/plugins/modules/remote_management/oneview/oneview_network_set_info.py @@ -51,10 +51,11 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about Network Sets + ansible.builtin.debug: msg: "{{ result.network_sets }}" -- name: Gather paginated, filtered, and sorted information about Network Sets +- name: Gather paginated, filtered and sorted information about Network Sets community.general.oneview_network_set_info: hostname: 172.16.101.48 username: administrator @@ -69,7 +70,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about paginated, filtered and sorted list of Network Sets + ansible.builtin.debug: msg: "{{ result.network_sets }}" - name: Gather information about all Network Sets, excluding Ethernet networks @@ -84,7 +86,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about Network Sets, excluding Ethernet networks + ansible.builtin.debug: msg: "{{ result.network_sets }}" - name: Gather information about a Network Set by name @@ -98,7 +101,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about Network Set found by name + ansible.builtin.debug: msg: "{{ result.network_sets }}" - name: Gather information about a Network Set by name, excluding Ethernet networks @@ -114,7 +118,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about Network Set found by name, excluding Ethernet networks + ansible.builtin.debug: msg: "{{ result.network_sets }}" ''' diff --git a/plugins/modules/remote_management/oneview/oneview_san_manager_info.py b/plugins/modules/remote_management/oneview/oneview_san_manager_info.py index 46ed001827b..284371cafc7 100644 --- a/plugins/modules/remote_management/oneview/oneview_san_manager_info.py +++ b/plugins/modules/remote_management/oneview/oneview_san_manager_info.py @@ -46,7 +46,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about SAN Managers + ansible.builtin.debug: msg: "{{ result.san_managers }}" - name: Gather paginated, filtered and sorted information about SAN Managers @@ -60,7 +61,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about paginated, filtered and sorted list of SAN Managers + ansible.builtin.debug: msg: "{{ result.san_managers }}" - name: Gather information about a SAN Manager by provider display name @@ -70,7 +72,8 @@ delegate_to: localhost register: result -- ansible.builtin.debug: +- name: Print fetched information about SAN Manager found by provider display name + ansible.builtin.debug: msg: "{{ result.san_managers }}" ''' From 9bbc4210a64249218aec75a159314c8f993d7851 Mon Sep 17 00:00:00 2001 From: Vitaly Khabarov Date: Sun, 17 Oct 2021 10:58:05 +0300 Subject: [PATCH 2/5] Fix task name in github_webhook module example --- plugins/modules/source_control/github/github_webhook.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/modules/source_control/github/github_webhook.py b/plugins/modules/source_control/github/github_webhook.py index 8703863fa94..fcb6f8d06f2 100644 --- a/plugins/modules/source_control/github/github_webhook.py +++ b/plugins/modules/source_control/github/github_webhook.py @@ -97,7 +97,7 @@ ''' EXAMPLES = ''' -- name: create a new webhook that triggers on push (password auth) +- name: Create a new webhook that triggers on push (password auth) community.general.github_webhook: repository: ansible/ansible url: https://www.example.com/hooks/ From c090506aa8ae4c9e9e38eea22b073ef7c5a6e873 Mon Sep 17 00:00:00 2001 From: Vitaly Khabarov Date: Sun, 17 Oct 2021 11:19:40 +0300 Subject: [PATCH 3/5] Fix trailing whitespace --- .../remote_management/oneview/oneview_datacenter_info.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/modules/remote_management/oneview/oneview_datacenter_info.py b/plugins/modules/remote_management/oneview/oneview_datacenter_info.py index 04a8bd922d4..bf3e9a87723 100644 --- a/plugins/modules/remote_management/oneview/oneview_datacenter_info.py +++ b/plugins/modules/remote_management/oneview/oneview_datacenter_info.py @@ -48,7 +48,7 @@ delegate_to: localhost register: result -- name: Print fetched information about Data Centers +- name: Print fetched information about Data Centers ansible.builtin.debug: msg: "{{ result.datacenters }}" From 690ba046f1078db5942208c6dd3b1145b9f8975a Mon Sep 17 00:00:00 2001 From: Vitaly Khabarov Date: Sun, 17 Oct 2021 11:19:52 +0300 Subject: [PATCH 4/5] Add changelog fragment --- changelogs/fragments/3572-misc-doc-issues.yml | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 changelogs/fragments/3572-misc-doc-issues.yml diff --git a/changelogs/fragments/3572-misc-doc-issues.yml b/changelogs/fragments/3572-misc-doc-issues.yml new file mode 100644 index 00000000000..1457d4d1285 --- /dev/null +++ b/changelogs/fragments/3572-misc-doc-issues.yml @@ -0,0 +1,3 @@ +--- +minor_changes: +- Add names to tasks in oneview module examples and fix task name in github_webhook module example (https://github.com/ansible-collections/community.general/issues/3353). From c32b1b2bee28e8bc23627e65505aa12121551d45 Mon Sep 17 00:00:00 2001 From: Vitaly Khabarov Date: Sun, 17 Oct 2021 17:31:58 +0300 Subject: [PATCH 5/5] Remove changelog fragment --- changelogs/fragments/3572-misc-doc-issues.yml | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 changelogs/fragments/3572-misc-doc-issues.yml diff --git a/changelogs/fragments/3572-misc-doc-issues.yml b/changelogs/fragments/3572-misc-doc-issues.yml deleted file mode 100644 index 1457d4d1285..00000000000 --- a/changelogs/fragments/3572-misc-doc-issues.yml +++ /dev/null @@ -1,3 +0,0 @@ ---- -minor_changes: -- Add names to tasks in oneview module examples and fix task name in github_webhook module example (https://github.com/ansible-collections/community.general/issues/3353).